-
Notifications
You must be signed in to change notification settings - Fork 48
feat: allow setting a consumption/production sensor in the flex-model of an asset #2190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
b02e111
feat: allow setting a power sensor in the flex_model of an asset when…
Flix6x db45c30
Merge remote-tracking branch 'origin/main' into feat/sensor-in-db-fle…
Flix6x 3ffdaa0
fix: fields without a data_key just use the variable name as data_key
Flix6x 4f5b116
feat: switch to consumption and production sensor reference fields in…
Flix6x c3f2d68
feat: add UI support for new fields
Flix6x 711e228
docs: document new fields in scheduling.rst
Flix6x 1fa459e
feat: add new fields to StorageFlexModelSchema
Flix6x ed640b2
chore: update openapi-specs.json
Flix6x 4733868
storage: add consumption and production output sensor support
Flix6x a96edd4
tests: expand storage scheduler tests for consumption/production outp…
Flix6x e63ee43
docs: document consumption/production output sensor semantics and add…
Flix6x 82c6015
style: black
Flix6x f9adee9
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/sen…
Flix6x 6d2b33b
Merge remote-tracking branch 'origin/main' into feat/sensor-in-db-fle…
Flix6x 4b1ab4f
fix: guard sensor_d against None in StorageScheduler._prepare
saerts-gp 5811ca8
Merge remote-tracking branch 'origin/main' into feat/sensor-in-db-fle…
Flix6x a8a3e9e
feat: resample from the resolution of the storage-efficiency sensor t…
Flix6x 1546e51
docs: extend field description accordingly
Flix6x d42f65f
fix: remove obsolete validator
Flix6x 9bd75ed
feat: do not allow storage-efficiency to be set without a known resol…
Flix6x d6e15b6
docs: fill in PR number
Flix6x 75fa2eb
docs: API changelog entry
Flix6x 9f173fa
docs: simplify main changelog entry
Flix6x 1033baf
feat: add more explicit checks in test
Flix6x 061389b
data/services/scheduling: fix double sign inversion for consumption/p…
Flix6x 7d902c3
fix: refine sign inversion logic for consumption/production output se…
Flix6x 82da372
refactor: extract sign resolution logic to utility function
Flix6x 40128b7
fix: explicitly set the consumption_is_positive attribute on consumpt…
Flix6x d5521d4
Merge remote-tracking branch 'origin/main' into feat/sensor-in-db-fle…
Flix6x 9e31174
feat: test fetching schedules from consumption and production sensors
Flix6x 6eae5c8
fix: set_attribute is a no-op when the attribute does not exist; also…
Flix6x 2cd8d25
feat: prevent mutating consumption_is_positive once it is set
Flix6x e2ccc08
data/services/scheduling: extract _set_output_sensor_consumption_is_p…
Flix6x e555ea4
api/v3_0/tests: add test for conflicting consumption_is_positive attr…
Flix6x 7038e53
fix: test expectations for production sensors
Flix6x a2a2b95
docs: clarify sign convention for the get_schedule endpoint
Flix6x dfbc2a0
feat: add sign-convention query parameter to get_schedule endpoint
Flix6x f19088c
docs: document sign-convention parameter for get_schedule endpoint
Flix6x 3e7b818
api/v3_0/tests: extend sign-convention tests to cover all three modes
Flix6x 5eb1772
docs: touch up sign explanations
Flix6x 99f5d90
docs: clarify how the scheduler records the data, mention the sign o…
Flix6x e29111c
docs: clarify confusing comments
Flix6x 7e6ab51
data/models/planning/storage: pass consumption-positive values to mak…
Flix6x 6905eac
data/services/scheduling: set consumption_is_positive at trigger time…
Flix6x 5600f6f
api/v3_0/tests: update conflict test to expect 422 at trigger time
Flix6x 36d685d
style: punctuation
Flix6x 8944fd4
Merge remote-tracking branch 'origin/main' into feat/sensor-in-db-fle…
Flix6x 2a7ca41
docs: clarify effect of setting consumption_is_positive
Flix6x c5f5124
fix: improve test quality
Flix6x 5ea784c
docs: use past tense to discriminate between what the endpoint does a…
Flix6x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.