Fix/set tokens#278
Open
HJordan35 wants to merge 4 commits into
Open
Conversation
|
✅ No documentation updates required. |
micahbf
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please explain how to summarize this PR for the Changelog:
The
FlatfileProvidersupports 2 props:When attempting to create NEW spaces, the publishableKey must be provided (accessKey must be null) - however, when re-using a space, and accessToken must be provided, while leaving publishableKey blank. However, if there is ever a need to support BOTH situations simultaneously (i.e. sometimes create a new space, sometimes re-use) there is not efficient way to update the FlatfileProvider
This update exposes the
setAccessTokenandsetPublishableKeyprops - exposed via theuseFlatfilehook so customers with this unique requirement can patch their provider depending on the use-case, without needing to perform a complete unmount/remount of their providerTell code reviewer how and what to test: