fix: skip exposure events when no identifier resolves#407
Merged
Conversation
trackExposureEvent emitted exposures with identifier: null for anonymous users; exposures without an assignment unit are unanalyzable. Now skips with a log, mirroring getExperimentFlag. Explicit opts.identifier still records an exposure; trackEvent is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
trackExposureEventemitted$flag_exposureevents withidentifier: nullwhen no identity was set; exposures without an assignment unit can't be attributed to a cohort. It now skips with a log when no identifier resolves, mirroringgetExperimentFlag. Explicitopts.identifierstill records;trackEventis unchanged. Nodocs/changes — the API is@experimental @internal; JSDoc updated.How did you test this code?
Test-first: a failing test reproducing the
identifier: nullexposure, then the guard, plus pin-down tests for explicitopts.identifierand anonymoustrackEvent. Full suite green (118 tests) vianpm test.