feat(v7): get_evaluation_result#239
Merged
Merged
Conversation
khvn26
force-pushed
the
feat/v7-get-evaluation-result
branch
2 times, most recently
from
August 12, 2025 11:14
ca412c7 to
fdd18f8
Compare
khvn26
force-pushed
the
feat/v7-get-evaluation-result
branch
from
August 12, 2025 11:15
fdd18f8 to
4364c6e
Compare
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d1f6414 |
khvn26
commented
Aug 12, 2025
khvn26
commented
Aug 12, 2025
khvn26
commented
Aug 12, 2025
khvn26
requested review from
a team and
gagantrivedi
and removed request for
a team
August 12, 2025 13:31
khvn26
commented
Aug 12, 2025
Co-authored-by: Evandro Myller <22429+emyller@users.noreply.github.com>
emyller
reviewed
Aug 15, 2025
khvn26
force-pushed
the
feat/v7-get-evaluation-result
branch
from
August 15, 2025 19:47
129108b to
fb31c9c
Compare
emyller
reviewed
Aug 16, 2025
Zaimwa9
reviewed
Aug 18, 2025
Zaimwa9
left a comment
Zaimwa9
left a comment
Contributor
There was a problem hiding this comment.
One NIT on my side, otherwise looks like we are reaching the end. Updated mappers in python-client accordingly
Zaimwa9
previously approved these changes
Aug 18, 2025
khvn26
enabled auto-merge (squash)
August 18, 2025 16:05
khvn26
disabled auto-merge
August 18, 2025 16:06
matthewelwell
left a comment
matthewelwell
left a comment
Contributor
There was a problem hiding this comment.
As per request from @khvn26 I have retrospectively reviewed the code. While I think there are sections which are quite complex, I can definitely see some of the benefits starting to appear. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #234.
For now, the PR maintains full backwards compatibility. Hopefully, we'll be able to release V7 without the old interfaces and models altogether. This should allow us do ditch the Pydantic dependency. Worst case scenario,
get_environment_feature_state[s]/get_identity_feature_state[s]will stay but produce aDeprecationWarning.I've started some threads to add my own notes on the code, everybody's welcome to add comments there.