fix(deps): add peft version constraint to avoid 0.18 incompatibility#1557
Open
majiayu000 wants to merge 1 commit intoFlagOpen:masterfrom
Open
fix(deps): add peft version constraint to avoid 0.18 incompatibility#1557majiayu000 wants to merge 1 commit intoFlagOpen:masterfrom
majiayu000 wants to merge 1 commit intoFlagOpen:masterfrom
Conversation
Pin peft to >=0.11.0,<0.18.0 to avoid breaking changes introduced in peft 0.18.0 which is incompatible with the current codebase. Fixes FlagOpen#1546 Signed-off-by: majiayu000 <1835304752@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>=0.11.0,<0.18.0to avoid breaking changes in peft 0.18Problem
peft 0.18 introduces breaking changes that are incompatible with the current codebase.
Test plan
Fixes #1546