Open
Conversation
added 8 commits
October 29, 2016 10:11
Gisonrg
reviewed
Nov 3, 2016
Member
Gisonrg
left a comment
Gisonrg
left a comment
There was a problem hiding this comment.
Please update according to comments.
Noted that don't wait for DB error to conclude that inputs are invalid.
| exports.updateUserSpritename = function(req, res) { | ||
| var query = { '_id': req.user._id }; | ||
| if (!req.body.spritename) { | ||
| res.send({ |
Member
There was a problem hiding this comment.
Add a return here
Add a status code (400)
| error: "Please input new spritename for update" | ||
| }); | ||
| } | ||
| var updateAttributes = { "spritename":req.body.spritename } |
Member
There was a problem hiding this comment.
Check not empty and limit the input length?
| updateAttributes['healthLimit'] = req.body.healthLimit | ||
| } | ||
| if (!updateAttributes.strength && !updateAttributes.stamina && !updateAttributes.agility && !updateAttributes.health && !updateAttributes.healthLimit) { | ||
| res.send({ |
Member
There was a problem hiding this comment.
condition should be || (reject as long as one input is not correct)
Also, specify the condition explicitly (for example, must be >= 0)
| exports.updateUserSkills = function(req, res) { | ||
| var query = { '_id': req.user._id }; | ||
| if (!req.body.skills) { | ||
| res.send({ |
Member
There was a problem hiding this comment.
return and status code, same for all codes below
| if (req.body.experience) { | ||
| updateAttributes['experience'] = req.body.experience | ||
| } | ||
| if (!updateAttributes.level && !updateAttributes.experience) { |
Member
There was a problem hiding this comment.
- condition should be
||(no level or no experience) - if
level == 0,!levelwill be true. Write explicit condition
| // Get user | ||
| router.get('/users/:id', verifyToken, authCtrl.refreshToken, userCtrl.getUser); | ||
| // Update user | ||
| router.post('/users', verifyToken, authCtrl.refreshToken, userCtrl.updateUser); |
Member
There was a problem hiding this comment.
Kept this method and its route for now. Not all users will upgrade to use Api v2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.