Repository navigation
Preserve calibrated motion with adaptive collision stepping - #9
Merged
Merged
Conversation
fred-huang122
marked this pull request as draft
November 3, 2026 18:22
fred-huang122
marked this pull request as ready for review
November 4, 2026 01:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recorded turns under-predict the response of Utama radio 1, and a 6 v 6 pushing/turning case exceeds the existing 2 mm shell-overlap bound. Refine the fitted radio 1 angular limits and use a shared adaptive integration schedule to preserve measured motion while resolving first impacts.
The adaptive policy uses two evenly spaced steps per fixed tick for settled, distant motion; at least five for startup, placement/reset, acceleration, turning, sliding or flight; and finer subdivisions for predicted robot, ball and wall impacts. Every body uses the same fixed simulation clock. The direct double-precision solver, collision geometry, contact material parameters and 2 mm bound are unchanged. Modern commands, legacy replacements, GUI placement/formation and automatic turnover resets all restart settling.
Replay v2 records the explicit integration policy. Historical v1 retains fixed-five physics; the prior near-shell-six policy also remains explicit. Controlled fixed-count replay supports the requested 1/2/3/5 comparisons. Unknown policies and incompatible version/count combinations are rejected.
Radio 1 angular speedup/braking limits change from 50 to 125 while its velocity gains and radio 0 remain unchanged. These are fitted simulator control settings, not measured hardware acceleration maxima. The original three withheld turns improve from median 6.95° to 3.22° heading RMSE; the expanded 13 turns improve from 2.98° to 1.83°. Stopping remains a disclosed trade-off: capture-clock median 2.17° → 2.00°, receive-clock median 2.09° → 2.14°.
Validation uses 84 physical movement events and 21 stopping phases from confirmed 27–28 October logs, plus 161 rolling-ball windows (28 held out from 11 source files). SIM, uncertain-origin, incomplete and contact-sensitive records remain separate. Parameters, initial poses, observation delays and original transmitted command cadence are frozen across integration comparisons. Actual capped commands are replayed; these data do not establish onboard maximum speeds. Weak/no-fire and off-centre kicks remain interpretation context; kicker physics is not retuned. This is development validation on the existing archive, not newly collected independent evidence.
Adaptive changes each movement's driving-axis RMSE by at most 0.033 mm versus fixed five; turning and stopping predictions are numerically unchanged at the reported precision. Held-out ball pooled RMSE is 18.628 mm with fixed five and 18.633 mm adaptive. No parameters were refitted to hide integration differences.
Three interleaved 15-second, 6 v 6 trials with three ODE helpers:
Adaptive is faster in separated motion and can cost more during dense impacts; every tested adaptive case exceeds real-time throughput, including the slowest sustained pushing case at 2.13×. Global fixed 1/2/3 are rejected: turning crowds exceed 2 mm. These are physics-only CPU timings, not rendered-FPS claims; user background workloads were left running. Synthetic impacts do not replace instrumented physical collision measurements.
Permanent regressions cover the ±2/±4 cases, front/back ball-robot shots, ball/robot-wall impacts, placement settling, exact serial repetition (1e-12), and the existing three-second helper comparison (1e-6). No fifteen-second cross-helper bitwise identity is claimed. All 28 local regressions pass. Standards and Spec review: zero unresolved findings after fixes. Raw logs, generated snapshots, private scripts and analysis remain outside Git.
CI: https://github.com/First-Order-RoboCup-SSL/grSim/actions/runs/41755171142
Validation complete: both Ubuntu 22.04/24.04 pass 28/28 tests; native Apple Silicon macOS 15/26 pass 27/27. The exact macOS 15 artifact (ID 13288466473, SHA256 8cfe5b61eccd2d8fabc95f491595a5b98d05f67a971e70d4c6502aaf4117936b) also launches on macOS 26 with both generic and field profiles. One targeted macOS 26 job retry was needed after an initial application-smoke timeout; the unchanged test passed in 6.23 s against the same 20 s limit. No checks or tolerances were weakened.