Skip to content

Fix zero-step replays and reject malformed settings XML - #7

Merged
fred-huang122 merged 1 commit into
masterfrom
fix/replay-capture-validation
Nov 2, 2026
Merged

fred-huang122 merged 1 commit into
masterfrom
fix/replay-capture-validation

Conversation

@fred-huang122

@fred-huang122 fred-huang122 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

A valid 50 ms command capture with a 100 ms physics timestep can finish without a physics step. Replay previously rejected that successful recording. Accept zero-tick timelines and apply their terminal commands without advancing physics.

Explicit settings now require well-formed XML with an unnamespaced VarXML root before loading. VarXML previously silently used defaults for empty, malformed or unrelated XML. Valid sparse configurations, XML declarations and comments remain supported.

Validation: reproduced both failures on the previous binary; the focused replay regression now passes. Added controls for malformed/wrong-root/namespaced/multiple-root XML and both empty and command-containing zero-tick timelines. All 27 local regressions pass in 87.70 seconds, including collision, ODE math, worker lifecycle, rendering and physics replay checks. Independent standards and behaviour reviews found no unresolved findings in the follow-up.

Follow-up to the review of #3–#6. Changes are limited to the replay tool and its regression; local reproduction data remain outside Git.

Follow-up CI passes both Ubuntu 22.04 and 24.04 builds and regressions. Native Apple Silicon macOS 15/26 jobs remain queued, so this follow-up has no fresh Mac result yet.

@fred-huang122
fred-huang122 merged commit b995989 into master Nov 2, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant