Repository navigation
Fix zero-step replays and reject malformed settings XML - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valid 50 ms command capture with a 100 ms physics timestep can finish without a physics step. Replay previously rejected that successful recording. Accept zero-tick timelines and apply their terminal commands without advancing physics.
Explicit settings now require well-formed XML with an unnamespaced VarXML root before loading. VarXML previously silently used defaults for empty, malformed or unrelated XML. Valid sparse configurations, XML declarations and comments remain supported.
Validation: reproduced both failures on the previous binary; the focused replay regression now passes. Added controls for malformed/wrong-root/namespaced/multiple-root XML and both empty and command-containing zero-tick timelines. All 27 local regressions pass in 87.70 seconds, including collision, ODE math, worker lifecycle, rendering and physics replay checks. Independent standards and behaviour reviews found no unresolved findings in the follow-up.
Follow-up to the review of #3–#6. Changes are limited to the replay tool and its regression; local reproduction data remain outside Git.
Follow-up CI passes both Ubuntu 22.04 and 24.04 builds and regressions. Native Apple Silicon macOS 15/26 jobs remain queued, so this follow-up has no fresh Mac result yet.