Repository navigation
Make the skybox an independent display setting - #10
Open
fred-huang122 wants to merge 1 commit into
Open
fred-huang122 wants to merge 1 commit into
fred-huang122 wants to merge 1 commit into
Conversation
Default the optional skybox to off and persist its value independently of Low Spec Mode. Exercise the setting in the existing rendering and settings regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Skybox visibility currently follows Low Spec Mode. Add a persistent Show Skybox setting that defaults to off and works in both detail modes. The live view and screenshots read the same setting. Editing it only changes rendering.
Verification
Release notes
Show Skybox can be enabled independently of Low Spec Mode.