Skip to content

Make the skybox an independent display setting - #10

Open
fred-huang122 wants to merge 1 commit into
masterfrom
render/skybox-toggle
Open

fred-huang122 wants to merge 1 commit into
masterfrom
render/skybox-toggle

Conversation

@fred-huang122

Copy link
Copy Markdown
Collaborator

Description of the change

Skybox visibility currently follows Low Spec Mode. Add a persistent Show Skybox setting that defaults to off and works in both detail modes. The live view and screenshots read the same setting. Editing it only changes rendering.

Verification

  • All 28 local tests passed on the final patch.
  • Rendering checks exercise off, on, and off again in both detail modes and at standard and HiDPI scale.
  • Settings checks cover old settings files, both persisted values, and the edit signal. The new edit check reproduced an unwanted physics reconfiguration and passes after the fix.
  • Standards and behavior reviews have no outstanding findings.

Release notes

Show Skybox can be enabled independently of Low Spec Mode.

Default the optional skybox to off and persist its value independently of Low Spec Mode. Exercise the setting in the existing rendering and settings regressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant