feat(vscode): add profile config foundation (1 of 5)#250
Merged
Conversation
11 tasks
veeso
force-pushed
the
feat/fir-405-vscode-profile-config
branch
from
July 9, 2026 15:05
993c16a to
bae76bd
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
|
Doing a pass focused on alias resolution via Codex seems to suggest we're not normalizing It might be the case that we are not using |
veeso
force-pushed
the
feat/fir-405-vscode-profile-config
branch
2 times, most recently
from
July 10, 2026 08:21
5ccfbd7 to
960b437
Compare
veeso
force-pushed
the
feat/fir-405-vscode-profile-config
branch
from
July 10, 2026 08:35
960b437 to
673badd
Compare
| monitor_mode: false, | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Let's add another test here that checks what happens when using the alias in the profile field.
[run]
profile = "code"
[run.profiles.vscode]
env_passthrough = ["FIRMA_ALIAS_CANARY"]
LukeMathWalker
approved these changes
Jul 10, 2026
LukeMathWalker
left a comment
Contributor
There was a problem hiding this comment.
Feel free to merge once the new test is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
What Changed
vscodeandcodeprofile recognition infirma-config-loader.FIRMA_CONFIG.Verification
Security Considerations
Risks
Model Used
Checklist
just checkpasses locally (fmt + toml-fmt + lint + test + build + audit + deny).unwrap(),.expect(),panic!(), orunsafeintroduced outside of test codedocs/anddocs-site/Chunks
This is part 1 of 5:
#250 #251 #252 #253 #254