Small Improvement to Performance Auto Tune feature#131
Open
Hecklezz wants to merge 2 commits intoFirestormViewer:masterfrom
Open
Small Improvement to Performance Auto Tune feature#131Hecklezz wants to merge 2 commits intoFirestormViewer:masterfrom
Hecklezz wants to merge 2 commits intoFirestormViewer:masterfrom
Conversation
c550f5e to
13d8870
Compare
Contributor
Author
|
I have also removed some old logic that was setting the max autotune view distance back to your viewers currently set settings every time you opened the viewer unless if you had the continuous setting left on when you logged out. I have removed this logic now so that way people who say have their render distance set to 256 normally, but are using the autotune set to a max of 512 when in a light region, it can do that and then relogging keeps it at 512 instead of reverting back to 256. |
…referred distance to 1024, and made some settings persist
13d8870 to
0667ad0
Compare
… every time you open the viewer.
Contributor
|
I don't think autotune is currently fit for purpose in any case. This PR is on hold until we can dive deeper in to it. Basically with all the pipeline changes for pbr the stats are no longer aligned and it needs to be verified once again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Performance Auto Tune feature (located under World->Improve Graphics Speed... or Advanced->Performance Tools->Improve Graphics Speed...) only has the options for Avatar only, or Avatar and Scene, there is no Scene only option. In the SLViewer, there is a Scene only option and the LLPerfStats implementation that Firestorm uses for the feature is already setup to work with Scene only.
This PR simply adds the dropdown option for Scene Only to be in-line with SLViewer and also for those who don't want the feature impacting Avatar Complexity. Another small change the PR makes, is increasing the preferred render distance maximum from 256 all the way up to 1024. Since I see no reason it should be limited to 256 if you are around regions that are easy to render and you could easily render over 256m at a target framerate, and then once you go to a more demanding region, it will dynamically drop it back under anyway.
I also changed a few of the auto tune settings that didn't persist to now persist, to save people the trouble of having to change them every single time you use the feature, which some people may want on all the time and kept it on across logging out and back in.
TODO: Translation request to add this additional combo box value (scene_only) for "FSTuningFPSStrategy" in all the floater_fs_performance.xml translations.