Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176.
-s3_fast -r,-g, and-bnow run only fast step 3. Previously theand not args.step_3_fastguard applied only to-rgb, so individual color flags triggered a full LED fit before repeating the analysis without fits. Grouping the color flags applies the guard to every channel selection.The regression tests parse real CLI flags and verify a single extractor invocation with the requested channels and fit mode. They cover each color, RGB, and a two-color selection with and without
-s3_fast. Before the fix, four fast-mode cases failed because extraction ran twice.Validation:
python -m pytest ledsa/tests/UnitTests -q— 413 passed (one existing normalization warning), Python 3.12 on macOS. Robot Framework image acceptance tests were not run; this change affects dispatch, not the extraction algorithms.