Skip to content

Apply the clock offset to the experiment time - #174

Merged
kriboe90 merged 1 commit into
masterfrom
claude/clock-offset-experiment-time-a4aab2
Oct 30, 2026
Merged

kriboe90 merged 1 commit into
masterfrom
claude/clock-offset-experiment-time-a4aab2

Conversation

@kriboe90

Copy link
Copy Markdown
Contributor

Fixes #173.

start_time is on the real clock: get_start_time subtracts exif_time_infront_real_time from the first image's EXIF time. Experiment_Time[s], however, was measured from the uncorrected EXIF time, so it was off by the offset:

  • For a single camera, the first image did not sit at t = 0.
  • For several cameras, the stacked analysis kept them apart by the difference of their offsets.

Change

  • _calc_experiment_and_real_time now measures the experiment time from the corrected image time.
  • New test file test_experiment_time_clock_offset.py with two tests:
    • when start_time is derived from the first image, that image is at 0;
    • two cameras with offsets of +30 s and −5 s and the same start_time get the same experiment times.

Both tests fail without the fix. All unit tests pass with it. The acceptance tests were not run locally.

Note

image_infos*.csv files written before this change, and any temperature reduction tables aligned to them, are shifted by the offset and need regenerating. The demo's times move by 1 s, because its offset is −1.

🤖 Generated with Claude Code

start_time is on the real clock, but Experiment_Time[s] was measured
from the uncorrected EXIF time, so every experiment time was off by
exif_time_infront_real_time and cameras with different offsets stayed
apart in the stacked analysis.

Fixes #173

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kriboe90
kriboe90 merged commit 207cb90 into master Oct 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clock offset (exif_time_infront_real_time) is not applied to Experiment_Time[s]

1 participant