Repository navigation
Apply the clock offset to the experiment time - #174
Merged
Merged
Conversation
start_time is on the real clock, but Experiment_Time[s] was measured from the uncorrected EXIF time, so every experiment time was off by exif_time_infront_real_time and cameras with different offsets stayed apart in the stacked analysis. Fixes #173 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #173.
start_timeis on the real clock:get_start_timesubtractsexif_time_infront_real_timefrom the first image's EXIF time.Experiment_Time[s], however, was measured from the uncorrected EXIF time, so it was off by the offset:Change
_calc_experiment_and_real_timenow measures the experiment time from the corrected image time.test_experiment_time_clock_offset.pywith two tests:start_timeis derived from the first image, that image is at 0;start_timeget the same experiment times.Both tests fail without the fix. All unit tests pass with it. The acceptance tests were not run locally.
Note
image_infos*.csvfiles written before this change, and any temperature reduction tables aligned to them, are shifted by the offset and need regenerating. The demo's times move by 1 s, because its offset is −1.🤖 Generated with Claude Code