feat: add accessible themeable Button component to design system - #1103
Open
Loisyy wants to merge 1 commit into
Open
feat: add accessible themeable Button component to design system#1103Loisyy wants to merge 1 commit into
Loisyy wants to merge 1 commit into
Conversation
- Variants: primary, secondary, danger, ghost - Sizes: sm, md, lg - States: default, hover, focus, disabled, loading (spinner + aria-busy) - Fully keyboard accessible (Enter/Space) - Focus ring via :focus-visible (invisible to mouse users) - Themed via CSS custom properties — flips with [data-theme='light'] - Storybook stories for all variants, sizes and states - 24 unit tests — all passing Closes FinesseStudioLab#969
|
@Loisyy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds the Button component for the shared design system per issue #969.
What's included
Button.jsx — accessible, themeable component
Button.css — styled via CSS custom properties, flips with [data-theme='light']
Button.stories.jsx — Storybook stories for all variants, sizes and states
Button.test.jsx — 24 unit tests, all passing
index.js — exports Button from the barrel
Variants
primary, secondary, danger, ghost
Sizes
sm, md, lg
States
default, hover, focus, disabled, loading (spinner + aria-busy)
Accessibility
Native element — correct role, keyboard and screen-reader support out of the box
aria-busy set while loading; visually-hidden "Loading" label keeps AT informed
aria-disabled + disabled both applied when disabled
Focus ring via :focus-visible — invisible to mouse users
Fully keyboard accessible via Enter and Space
Testing
24 unit tests covering all variants, sizes, states, keyboard interactions and accessibility attributes — all passing. No existing tests broken.
Closes #969