Repository navigation
Improve Markdown link target validation - #254
Open
Nagulanvelu wants to merge 1 commit into
Open
Nagulanvelu wants to merge 1 commit into
Nagulanvelu wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and scope
The local Markdown link validation test does not correctly handle link destinations containing optional quoted titles or angle brackets. This can cause valid local links to be interpreted as incorrect file paths.
This change focuses only on improving Markdown link target parsing in the repository quality tests.
What changed
markdown_link_target()helper to normalize Markdown link destinations.Verification
python -m black --config .github/quality/pyproject.toml --check .github/quality/testspython -m flake8 --config .github/quality/.flake8 .github/quality/testspython -m pytest -c .github/quality/pyproject.toml .github/quality/tests— 908 passedWorkflow-pack checks
Not applicable. This change does not add or modify a pre-built workflow pack.
Remaining limitations
The existing regular expression is not a complete CommonMark parser and may not handle every valid Markdown link syntax, including destinations containing complex parentheses. This change addresses quoted titles and angle-bracket destinations without introducing a full Markdown parser.