ci: backport latest add-to-project workflow, rename FS -> FOC#50
Merged
Conversation
Backports the current best version of the add-issues-and-prs workflow (as running in FilOzone/synapse-sdk) into the canonical sample here: - pin actions/add-to-project to the v2.0.0 commit hash (was v1.0.2) - add continue-on-error so the job does not fail when an item is already on the board - expand the pull_request_target security rationale comment Also aligns naming with the board it targets (org project #14 is the FOC board, not "FS"): - git mv ...-to-fs-project-board.yml -> ...-to-foc-project-board.yml - update workflow name and comments to say "FOC project board" - capitalize the job name "prs" -> "PRs" for consistency Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
The following access changes will be introduced as a result of applying the plan: Access Changes |
Contributor
|
Before merge, verify that all the following plans are correct. After merge, Apply will regenerate the plans from the merged commit and continue only if they match. Terraform plansFilOzoneNo changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed. |
There was a problem hiding this comment.
Pull request overview
Updates the canonical “add issues and PRs to project board” workflow template to the latest variant and aligns naming/comments with the org’s FOC project board, so downstream repos that manually copy this file stay consistent and up to date.
Changes:
- Pin
actions/add-to-projectto thev2.0.0commit SHA and addcontinue-on-error: trueto avoid failing when the item is already on the board. - Expand
pull_request_targetsecurity rationale comments. - Rename FS → FOC in workflow name/comments and normalize job display text casing.
Comments suppressed due to low confidence (3)
files/workflows/add-issues-and-prs-to-foc-project-board.yml:40
continue-on-error: truewill suppress all failures fromactions/add-to-project(e.g., missing/invalidFILOZZY_CI_ADD_TO_PROJECT, rate limits, API changes), making it easy for the workflow to silently stop adding items. Consider keeping the non-failing behavior but emitting an explicit warning when the action fails so the failure is visible in the run summary/logs.
files/workflows/add-issues-and-prs-to-foc-project-board.yml:34- Because this runs on
pull_request_target(with access to secrets), it’s safer to explicitly dropGITHUB_TOKENpermissions unless they’re needed. This workflow uses a PAT secret (FILOZZY_CI_ADD_TO_PROJECT) and doesn’t otherwise requireGITHUB_TOKEN, so addingpermissions: {}reduces the blast radius if anything unexpected tries to use the default token.
files/workflows/add-issues-and-prs-to-foc-project-board.yml:14 - The PR description says the canonical workflow was renamed from
…-to-fs-project-board.ymlto…-to-foc-project-board.yml, but the repo still contains.github/workflows/add-issues-and-prs-to-fs-project-board.yml, and it links tofiles/workflows/add-issues-and-prs-to-fs-project-board.yml(which no longer exists). This leaves an FS/FOC mismatch and a stale reference that can confuse future copy/paste updates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rjan90
approved these changes
Jul 6, 2026
Addresses review feedback on the FOC project-board workflow:
- Add permissions: {} to the distributable template. The job uses the
FILOZZY_CI_ADD_TO_PROJECT PAT and not the default GITHUB_TOKEN, so
dropping its permissions limits blast radius under pull_request_target.
This matches the hardening already present in github-mgmt's own copy.
- git mv github-mgmt's own .github/workflows copy from ...-to-fs- to
...-to-foc-project-board.yml and align its content with the template,
removing the now-stale link to the renamed files/ path so the two
copies are identical (github-mgmt dogfoods the template it ships).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Addressed the Copilot review points in 38112e4:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Backports the latest-and-greatest version of the "add issues and PRs to project board" workflow (the one currently running in FilOzone/synapse-sdk) into the canonical sample that lives here and is manually copied to other repos.
Functional changes:
actions/add-to-projectto the v2.0.0 commit hash (wasv1.0.2).continue-on-error: trueso the job doesn't fail when an item is already on the board (the action doesn't handle that case gracefully).pull_request_targetsecurity-rationale comment.Naming cleanup (org project #14 is the FOC board, not "FS"):
git mv…-to-fs-project-board.yml→…-to-foc-project-board.yml.name:and comments to say "FOC project board".prs→PRsfor consistency.Why
A recent audit found issues/PRs opened across the org that never made it onto the FOC board because several repos either lacked this workflow or ran an older/issues-only variant. While fixing those repos, the "FS" naming was flagged as confusing (by a Copilot review on foc-gh#11) since the board is FOC. This updates the source of truth so future copies are correct and consistent.
Note
Per the header, this file is manually copied to other repos, so merging this does not auto-propagate. The downstream repos being fixed in parallel (foc-gh#11, foc-observer#74, team-skills#6, security-triage#9) are being updated to match this content and filename.