Skip to content

chore(queue): split nonessential hardening from edit fencing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fclem wants to merge 2 commits into from
Closed

chore(queue): split nonessential hardening from edit fencing #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
759e3c2
fix: drop orphaned CI auto-fix queue rows without reservation
Fclem Sep 7, 2026
dad8fe3
fix(task): route queue schema probe through db dialect
Fclem Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/backend/internal/orchestrator/ci_automation_attempt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,10 @@ func (s *Service) reconcileOrphanedCIAutoFixQueueEntries(
continue
}
}
if ackErr := s.messageQueue.AcknowledgeQueued(
context.WithoutCancel(ctx), &entry,
); ackErr != nil {
return fmt.Errorf("remove orphaned CI auto-fix queue entry %q: %w", entry.ID, ackErr)
if removeErr := s.messageQueue.RemoveEntry(
context.WithoutCancel(ctx), entry.SessionID, entry.ID,
); removeErr != nil && !errors.Is(removeErr, messagequeue.ErrEntryNotFound) {
return fmt.Errorf("remove orphaned CI auto-fix queue entry %q: %w", entry.ID, removeErr)
}
}
return nil
Expand Down
9 changes: 1 addition & 8 deletions apps/backend/internal/task/repository/sqlite/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2920,14 +2920,7 @@ func unmarshalSessionSnapshots(
// in this task transaction. Some repository unit tests intentionally omit the
// message queue schema; production databases always include it.
func (r *Repository) queueSessionLockTablePresent(ctx context.Context) (bool, error) {
var present bool
var err error
if dialect.IsPostgres(r.db.DriverName()) {
err = r.db.GetContext(ctx, &present, `SELECT to_regclass('queue_session_locks') IS NOT NULL`)
} else {
err = r.db.GetContext(ctx, &present, `SELECT EXISTS (SELECT 1 FROM sqlite_master WHERE type = 'table' AND name = 'queue_session_locks')`)
}
return present, err
return db.TableExistsContext(ctx, r.db, "queue_session_locks")
}

// DeleteTaskSession deletes the exact session incarnation and its pending queue
Expand Down
Loading