Skip to content

Fix clean runner release restore#5

Merged
FaulMit merged 1 commit into
mainfrom
agent/fix-release-runtime-restore
Jul 22, 2026
Merged

Fix clean runner release restore#5
FaulMit merged 1 commit into
mainfrom
agent/fix-release-runtime-restore

Conversation

@FaulMit

@FaulMit FaulMit commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Summary

Restore the .NET runtime packs for win-x64 before running self-contained publish with --no-restore.

Root cause

The release script restored without a runtime identifier, then published with -r win-x64 --no-restore. Developer machines with cached runtime packs passed, while a clean GitHub runner failed with NETSDK1112 for Microsoft.NETCore.App.Runtime.win-x64 and Microsoft.WindowsDesktop.App.Runtime.win-x64.

Validation

  • reproduced from failed release run 29939258182
  • rebuilt the 0.1.2 portable package using a fresh artifacts directory
  • restore, self-contained publish, native bridge build, ZIP creation, and checksum generation passed

After merge, the 0.1.2 release workflow will be dispatched again.

@FaulMit
FaulMit merged commit 108e38f into main Jul 22, 2026
5 of 6 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d2ae16975

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/BuildRelease.ps1
dotnet restore $project --locked-mode --artifacts-path $dotnetArtifacts
dotnet restore $project `
--locked-mode `
--runtime win-x64 `

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the self-contained runtime packs

On a clean .NET 9 runner with no runtime packs cached, this restore is still framework-dependent: the .NET 8+ SDK behavior says a RID no longer implies SelfContained, and PublishSingleFile implies it only during dotnet publish, not dotnet restore. The publish immediately below uses --self-contained true --no-restore, so it can still request the Microsoft.NETCore.App/WindowsDesktop runtime packs that this restore did not download and hit NETSDK1112; pass -p:SelfContained=true here too, or set SelfContained in the project.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant