Repository navigation
fix: scope completion idempotency to its workflow - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The completion lookup mixed operation keys belonging to independent workflows. Query the owned workflow and operation together while retaining stage-consistency checks. Reviewed all operation_id and stage_completions sites in internal/workflow and internal/httpapi. Regression reproduced the cross-account collision before the fix and passes after it; also exercises an outbox insert failure, transaction rollback, recovery with the same operation and exactly-once events. Validation: Linux go test -race ./... -count=1 -timeout=180s passed. Closes #4. Closes #5.