Repository navigation
fix: preserve current file sessions and reject binary text writes - #7
Merged
Merged
Conversation
Contributor
Author
|
Final review complete: save acknowledgements update the baseline without overwriting newer drafts; old open/save/resync responses are scoped to their owning file session; binary text validation runs before directory creation or writes. Reviewed all five changed files and the concurrency regressions. CI verify passed full typecheck, lint, tests and build on this exact head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track file-session ownership for asynchronous opens, saves and resyncs; preserve edits made during writes. Reject binary content at the workspace write boundary before changing files or directories. Validation: web 62 tests and workspace 16 tests passed; targeted gateway workspace HTTP regression passed; web/workspace/gateway typechecks passed. Full Windows gateway run timed out, so full gateway success is not claimed. Closes #3. Closes #4.