Repository navigation
fix(web): preserve modal drafts on outside clicks - #7
Merged
Merged
Conversation
Contributor
Author
|
Reviewed all four changed files. Shared FastUI dismissal policy fixes both unsaved-input editors; navigation and delete confirmation retain their existing behavior. The author-backdrop regression failed before the fix and passed afterwards across desktop, mobile and subpath. Explicit cancel/close/save and reload persistence are exercised. No API, data format, dependencies or custom modal code changed. CI validate passed; release/deploy are intentionally inapplicable on this PR. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Verification
Scope review
Searched all web/src Dialog sites. Author and impression editors contain unsaved inputs and use explicit dismissal. Mobile navigation and delete confirmation contain no editable drafts and retain their existing behavior. Product net growth is one line; browser coverage adds fourteen lines; checkout policy adds one line. No new dependencies or private modal implementation.
Partially addresses #1; the umbrella issue remains open for report UX, author filtering/progress and future conference coverage.