Skip to content

fix(web): preserve modal drafts on outside clicks - #7

Merged
HsukqiLee merged 1 commit into
mainfrom
fix/preserve-modal-drafts
Nov 14, 2026
Merged

HsukqiLee merged 1 commit into
mainfrom
fix/preserve-modal-drafts

Conversation

@HsukqiLee

Copy link
Copy Markdown
Contributor

Changes

  • Prevent passive dismissal of author and research-impression editors with the existing FastUI dismissible policy; explicit close, cancel and save remain available.
  • Extend the production browser scenario to cover outside clicks, preserved field values and explicit author-editor exits.
  • Pin shell-script checkouts to LF so Windows-cloned repositories can run their Linux browser-test servers.

Verification

  • Reproduced 9-4日用户体验优化 #1 author draft loss before the fix: clicking outside removed the editor and failed the new assertion.
  • After the fix: 20 browser scenarios passed across desktop, mobile, private mode and /news subpath. Two inapplicable root/mobile subpath-only cases were skipped; the actual subpath case passed.
  • Root and /news frontend builds and TypeScript checks passed; full Go tests passed.

Scope review

Searched all web/src Dialog sites. Author and impression editors contain unsaved inputs and use explicit dismissal. Mobile navigation and delete confirmation contain no editable drafts and retain their existing behavior. Product net growth is one line; browser coverage adds fourteen lines; checkout policy adds one line. No new dependencies or private modal implementation.

Partially addresses #1; the umbrella issue remains open for report UX, author filtering/progress and future conference coverage.

@HsukqiLee

Copy link
Copy Markdown
Contributor Author

Reviewed all four changed files. Shared FastUI dismissal policy fixes both unsaved-input editors; navigation and delete confirmation retain their existing behavior. The author-backdrop regression failed before the fix and passed afterwards across desktop, mobile and subpath. Explicit cancel/close/save and reload persistence are exercised. No API, data format, dependencies or custom modal code changed. CI validate passed; release/deploy are intentionally inapplicable on this PR.

@HsukqiLee
HsukqiLee merged commit 610e39b into main Nov 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant