Skip to content

Fix Sonarqube Issues#2

Merged
FastPix-dev merged 2 commits into
mainfrom
fix/sonarqube-issues
Jun 3, 2026
Merged

Fix Sonarqube Issues#2
FastPix-dev merged 2 commits into
mainfrom
fix/sonarqube-issues

Conversation

@sid-fastpix
Copy link
Copy Markdown
Collaborator

@sid-fastpix sid-fastpix commented Jun 2, 2026

Description

  • Updates Core SDK version to 1.3.1
  • Refactors track handling in FastPixBaseMedia3Player to use List<TrackGroup> instead of TrackGroupArray
  • Optimizes bandwidth and rendition tracking logic for better collection of video metadata
  • Updates ReelActivity with improved scroll position detection and locale-aware time formatting
  • Improves null safety and string handling in VideoPlayerActivity error logging
  • Minor code cleanup and refactoring in VideoAdapter and ReelActivity

Screenshot

image

- Updates Core SDK version to 1.3.1
- Refactors track handling in `FastPixBaseMedia3Player` to use `List<TrackGroup>` instead of `TrackGroupArray`
- Optimizes bandwidth and rendition tracking logic for better collection of video metadata
- Updates `ReelActivity` with improved scroll position detection and locale-aware time formatting
- Improves null safety and string handling in `VideoPlayerActivity` error logging
- Minor code cleanup and refactoring in `VideoAdapter` and `ReelActivity`
@sid-fastpix sid-fastpix requested a review from Sravani289 June 2, 2026 07:23
@sid-fastpix sid-fastpix self-assigned this Jun 2, 2026
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Jun 2, 2026

DeepSource Code Review

We reviewed changes in eae7ca6...267b356 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Kotlin Jun 2, 2026 7:29a.m. Review ↗
Secrets Jun 2, 2026 7:29a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

…hecking

- Improves null safety and readability in track format processing
@FastPix-dev FastPix-dev merged commit cde30e7 into main Jun 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants