Fix Sonarqube Issues#2
Merged
Merged
Conversation
- Updates Core SDK version to 1.3.1 - Refactors track handling in `FastPixBaseMedia3Player` to use `List<TrackGroup>` instead of `TrackGroupArray` - Optimizes bandwidth and rendition tracking logic for better collection of video metadata - Updates `ReelActivity` with improved scroll position detection and locale-aware time formatting - Improves null safety and string handling in `VideoPlayerActivity` error logging - Minor code cleanup and refactoring in `VideoAdapter` and `ReelActivity`
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Kotlin | Jun 2, 2026 7:29a.m. | Review ↗ | |
| Secrets | Jun 2, 2026 7:29a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
…hecking - Improves null safety and readability in track format processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FastPixBaseMedia3Playerto useList<TrackGroup>instead ofTrackGroupArrayReelActivitywith improved scroll position detection and locale-aware time formattingVideoPlayerActivityerror loggingVideoAdapterandReelActivityScreenshot