Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
EVPN withdrawal metrics are incorrect, and full-table snapshots and cleanup introduce significant scalability problems.
Review effort: Balanced
Findings: 3
Open (3)
What changed in this PR
Adds tenant-aware EVPN route monitoring across the RIB, REST API, CLI, MRT/BGP ingestion, and BMP output, including ADD-PATH support.
Changes:
- Adds EVPN NLRI decoding, storage, filtering, and lifecycle handling.
- Adds REST and CLI querying with RD, RT, type, VNI, prefix, and ingress filters.
- Adds EVPN BMP replay, capabilities, documentation, and tests.
| File | Description |
|---|---|
test-data/cli/evpn-routes.json |
Adds CLI rendering fixtures. |
src/units/rib_unit/rib.rs |
Adds EVPN storage and lifecycle integration. |
src/units/rib_unit/mod.rs |
Exposes the EVPN module. |
src/units/rib_unit/http_ng.rs |
Adds the EVPN query endpoint. |
src/units/rib_unit/evpn.rs |
Implements EVPN decoding and metadata extraction. |
src/units/mrt_file_in/unit.rs |
Enables EVPN for MRT update ingestion. |
src/units/bmp_tcp_out/client_handler.rs |
Includes EVPN in initial BMP dumps. |
src/units/bmp_tcp_out/bmp_builder.rs |
Builds EVPN BMP updates and EORs. |
src/roto_runtime/types.rs |
Converts EVPN and ADD-PATH NLRIs. |
src/roto_runtime/runtime.rs |
Exposes EVPN Roto helpers. |
src/payload.rs |
Adds EVPN to the route payload model. |
src/bin/netom-cli/tree.rs |
Adds EVPN command grammar and filters. |
src/bin/netom-cli/commands/mod.rs |
Registers the EVPN CLI module. |
src/bin/netom-cli/commands/evpn.rs |
Implements EVPN querying and rendering. |
README.md |
Advertises EVPN monitoring. |
docs/rib-query-api.md |
Documents the EVPN endpoint. |
docs/index.md |
Adds EVPN documentation navigation. |
docs/evpn.md |
Documents EVPN behavior and limitations. |
docs/cli.md |
Documents EVPN CLI commands. |
doc/netom-cli.1 |
Adds the EVPN man-page entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nuclearcat
self-requested a review
October 2, 2026 08:15
nuclearcat
requested changes
Oct 2, 2026
jbemmel
marked this pull request as draft
October 2, 2026 12:11
Author
|
I'm thinking given the potentially large impact and trade-offs involved, it's probably better to require an explicit opt-in for this feature. Added a global |
jbemmel
marked this pull request as ready for review
October 2, 2026 13:11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds support for monitoring BGP L2VPN EVPN routes through BGP and BMP, including ADD-PATH sessions.
What’s included
GET /api/v1/ribs/l2vpnevpn/routesandnetom-cli show evpn, with filters for RD, route target, route type, VNI, prefix, ingress, and retained withdrawn routes.Label fields are exposed as raw 24-bit values; the VNI filter matches these values for VXLAN monitoring. Withdrawn records are available when withdrawn-attribute retention is enabled.
Why this matters
EVPN monitoring provides visibility into advertised overlay state across tenants and forwarding domains. Route-target filtering supports inspection across multiple RDs, while separating route identity from forwarding attributes enables consistent tracking of route updates and withdrawals.
This provides a foundation for analyzing EVPN fabrics, correlating MAC-VRF and IP-VRF advertisements, and deriving resource inventories from observed control-plane data. It reports advertised state without inferring VRF membership, assigning L2/L3 VNI roles, or simulating import policy and forwarding resolution.