Fixed the type conversion for the addresses list at isAddrOKCallback callback#79
Open
MoonSer wants to merge 1 commit into
Open
Conversation
Signed-off-by: moonser <zuev_8@mail.ru>
MoonSer
force-pushed
the
fix_windows_callback_args_converting
branch
from
c4d25d7 to
0d0139b
Compare
Author
|
By the way, do someone know at least one reason why the Windows implementation ignores the host being used? I've prepared the edits. It seems to be working, but I doubt it. Maybe they're sturdy crutches? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
By converting char* (8 bytes) to an unsigned long (4 bytes), part of the pointer is discarded. As a result, after reverse conversion on 64-bit Windows, we get SIGSEGV when dereferencing (or UB).
(function specified at WSAAccept )
So, using FCGI_WEB_SERVER_ADDRS env. variable - is DEAD for Windows x64.