[OoT] Fix/workaround decomp extracting params macroified#681
Merged
Yanis002 merged 3 commits intoFast-64:mainfrom Mar 16, 2026
Merged
[OoT] Fix/workaround decomp extracting params macroified#681Yanis002 merged 3 commits intoFast-64:mainfrom
Yanis002 merged 3 commits intoFast-64:mainfrom
Conversation
The workaround is to try set the params value, and if it fails then fallback to using the actor as "custom", setting the custom actor id and custom params.
Yanis002
approved these changes
Mar 14, 2026
Collaborator
Yanis002
left a comment
There was a problem hiding this comment.
it seems these changes are working like expected (I tested with kokiri forest and fire temple), though in the future I think we should add proper support for this instead of relying on the custom stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decomp recently started extracting params macroified like
ENDOOR_PARAMS_NODATA(DOOR_ROOMLOAD, false)instead of as just raw hex0x003Ffor example this is an excerpt from
extracted/gc-eu-mq-dbg/assets/scenes/dungeons/Bmori1/Bmori1_scene_02000090_TransitionActorEntryList.inc.c:{ { // { room, bgCamIndex } { 11, -1 }, { 8, -1 }, }, // sides ACTOR_EN_DOOR, { -1502, 523, -1864 }, // pos -0x8000, // rotY ENDOOR_PARAMS_NODATA(DOOR_ROOMLOAD, false) /* 0x003F */, // params }, // 4This breaks fast64 importing for two unrelated reasons:
split_c_on_commaswhich splits on commas but ignoring commas inside parenthesesThe workaround for the second point is to try set the params value, and if it fails then fallback to using the actor as "custom", setting the custom actor id and custom params.