Skip to content

Demo + fixes#12

Merged
SalmaElsoly merged 25 commits into
mainfrom
demo
Jun 22, 2025
Merged

Demo + fixes#12
SalmaElsoly merged 25 commits into
mainfrom
demo

Conversation

@SalmaElsoly

Copy link
Copy Markdown
Collaborator

Changes

Related issues

Checks

  • unit testing
  • documentation
  • build check
  • code format and docstring

@SalmaElsoly SalmaElsoly marked this pull request as draft June 21, 2025 15:07
@SalmaElsoly SalmaElsoly requested a review from Copilot June 21, 2025 15:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up test imports, enhances workflow execution by adding input/output serialization and a custom action_name parameter, and updates the discovery and timestamp handling in the core application.

  • Cleaned up and reordered imports across multiple test files.
  • Added serialize_data for all log inputs/outputs and an optional action_name to execute_action.
  • Changed /discover to return a list instead of a dict and standardized timestamps to UTC.

Reviewed Changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.

File Description
src/app/workflow_context.py Added serialize_data, action_name, and custom log names
src/app/types.py Standardized timestamps to UTC and renamed retry key
src/app/app.py Updated /discover output shape to return a list
Comments suppressed due to low confidence (2)

src/app/app.py:82

  • Changing /discover to return a raw list instead of { services: [...] } is a breaking change for API consumers. Please confirm compatibility or bump the API version.
        return [

src/app/workflow_context.py:58

  • New action_name parameter and serialization logic need corresponding unit tests to verify custom log names and correct serialization of inputs/outputs.
    async def execute_action(

Comment thread src/app/workflow_context.py
@SalmaElsoly SalmaElsoly marked this pull request as ready for review June 22, 2025 12:21
@Farahtharwat35 Farahtharwat35 self-requested a review June 22, 2025 12:24
@SalmaElsoly SalmaElsoly merged commit 47cafa5 into main Jun 22, 2025
4 checks passed
@Farahtharwat35 Farahtharwat35 deleted the demo branch June 30, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants