SDK-Testing#11
Merged
Merged
Conversation
This reverts commit 6cca019.
SalmaElsoly
requested changes
Jun 19, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive changes to the SDK’s testing suite, workflow execution logic, internal client, service registry and overall application integration. Key updates include:
- Overhauling the workflow execution and retry logic in WorkflowContext and internal workflow modules.
- Revising the Service and ServiceRegistry APIs including parameter validation and endpoint route registration.
- Updating test suites, configurations and project files for consistency and enhanced error handling.
Reviewed Changes
Copilot reviewed 28 out of 35 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/* | New and updated tests cover diverse execution, error, and retry scenarios. |
| src/app/workflow_context.py | Enhanced execution logic, retry handling, and updated docs. |
| src/app/service.py | Improved workflow decorator with stricter input signature validation. |
| src/app/_internal/* | Revised internal client and registry implementations. |
| src/app/app.py | Updated DurableApp with extended service discovery and error handling. |
| Other config files (pyproject.toml, Makefile, etc.) | Minor adjustments to build, testing, and linting configurations. |
SalmaElsoly
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing Scenarios Overview
TestApp (test_app.py)
2- Router Registration
3- Error Handling
4- Multiple Services
TestService (test_service.py)
1- Workflow Decorator
2- Parameter Validation
3- Multiple Registration
TestWorkflow (test_workflow.py)
1-Type System
2-Handler Routes
3-Type Description
TestInternalClient (test_internal_client.py)
1-Log Operations
2-Configuration
3-Error Scenarios
TestWorkflowContext (test_workflow_context.py)
1-Action Execution
2-Retry Mechanism
3-Idempotency
4-Error Handling
TestServiceRegistry (test_service_registry.py)
1-Registration
2-Service Listing
Checks