Improve AltGr modifier triggering detection#965
Open
johnd0e wants to merge 2 commits intoFarGroup:masterfrom
Open
Improve AltGr modifier triggering detection#965johnd0e wants to merge 2 commits intoFarGroup:masterfrom
johnd0e wants to merge 2 commits intoFarGroup:masterfrom
Conversation
johnd0e
force-pushed
the
fix-altgr
branch
3 times, most recently
from
fafc506 to
0f75538
Compare
Contributor
Author
test.luapanel.GetUserScreen()
mf.printconsole "Press key ('Esc' to quit)"
repeat
local key = mf.waitkey()
mf.printconsole(key)
until key=="Esc"
panel.SetUserScreen() |
Contributor
Author
A press/release of AltGr is translated by the system into the press/release of two keys - LCtrl and RAlt. In Far, for modifiers, activation is registered upon release, and the problem with AltGr is that, being a combined event, it triggered upon the release of the very first key in the combination - LCtrl, thereby producing "CtrlRAlt" instead of the expected "RAlt" (similarly for compound combinations). This patch prevents premature reaction to the LCtrl release event.
|
Contributor
Author
|
@zg0 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A press/release of AltGr is translated by the system into the press/release of two keys - LCtrl and RAlt. In Far, for modifiers, activation is registered upon release, and the problem with AltGr is that, being a combined event, it triggered upon the release of the very first key in the combination - LCtrl, thereby producing "CtrlRAlt" instead of the expected "RAlt" (similarly for compound combinations).
This patch prevents premature reaction to the LCtrl release event.