Skip to content

[stable/vpa] Add Release.Namespace to vpa admission certgen job resources#1818

Open
Azahorscak wants to merge 1 commit into
FairwindsOps:masterfrom
Azahorscak:claude/add-namespace-admission-jobs-GzRR0
Open

[stable/vpa] Add Release.Namespace to vpa admission certgen job resources#1818
Azahorscak wants to merge 1 commit into
FairwindsOps:masterfrom
Azahorscak:claude/add-namespace-admission-jobs-GzRR0

Conversation

@Azahorscak
Copy link
Copy Markdown
Member

@Azahorscak Azahorscak commented May 20, 2026

Set metadata.namespace to {{ .Release.Namespace }} on the namespaced admission certgen resources (jobs, role, rolebinding, serviceaccount) so they are created in the release namespace rather than the kubectl default.

Why This PR?
The resources in https://github.com/FairwindsOps/charts/tree/master/stable/vpa/templates/webhooks/jobs are not namespaced per the .Release.Namespace field.

Fixes # #1780

Changes
Changes proposed in this pull request:

  • Adds releaseNamespace as tthe namespace for all webhook related job manifests

Checklist:

  • I have included the name of the chart in the title of this PR in square brackets i.e. [stable/goldilocks].
  • I have updated the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • Any new values have been added to the README for the Chart, or helm-docs --sort-values-order=file has been run for the charts that support it.

Set metadata.namespace to {{ .Release.Namespace }} on the namespaced
admission certgen resources (jobs, role, rolebinding, serviceaccount) so
they are created in the release namespace rather than the kubectl default.

https://claude.ai/code/session_01CSYMirkLZ9uQP6zhy1Hb2g
@Azahorscak Azahorscak requested a review from sudermanjr as a code owner May 20, 2026 04:15
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants