[stable/vpa] Add Release.Namespace to vpa admission certgen job resources#1818
Open
Azahorscak wants to merge 1 commit into
Open
[stable/vpa] Add Release.Namespace to vpa admission certgen job resources#1818Azahorscak wants to merge 1 commit into
Azahorscak wants to merge 1 commit into
Conversation
Set metadata.namespace to {{ .Release.Namespace }} on the namespaced
admission certgen resources (jobs, role, rolebinding, serviceaccount) so
they are created in the release namespace rather than the kubectl default.
https://claude.ai/code/session_01CSYMirkLZ9uQP6zhy1Hb2g
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set metadata.namespace to {{ .Release.Namespace }} on the namespaced admission certgen resources (jobs, role, rolebinding, serviceaccount) so they are created in the release namespace rather than the kubectl default.
Why This PR?
The resources in https://github.com/FairwindsOps/charts/tree/master/stable/vpa/templates/webhooks/jobs are not namespaced per the .Release.Namespace field.
Fixes # #1780
Changes
Changes proposed in this pull request:
Checklist:
[stable/goldilocks].Chart.yamlfollowing Semantic Versioning.helm-docs --sort-values-order=filehas been run for the charts that support it.