This repository was archived by the owner on Oct 5, 2026. It is now read-only.
Repository navigation
docs(auth-core): state that the fixation revoke skips form_post (#36) - #44
Merged
Merged
Conversation
`issue()` and `Login::presented_cookie` implied the presented session is always revoked. It is not: on a form_post callback the SameSite=Lax cookie does not arrive, so presented_cookie is None and the revoke does not fire. That is not exploitable — the cookie is __Host- and HttpOnly, so it cannot be planted cross-site (the attack the revoke defends), and the browser overwrites it anyway; only the old server-side row lingers until expiry. Documented so a reader stops drawing the wrong conclusion, per #36. Firing it on every path (sealing the session id into the flow + a presented_session_id on Login) is the option-1 change left on the issue. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the "a reader draws the wrong conclusion" concern in #36 without changing the public API.
issue()andLogin::presented_cookieread as "always revokes the presented session." On aform_postcallback theSameSite=Laxcookie does not arrive, sopresented_cookieisNoneand the revoke does not fire. Not exploitable (the cookie is__Host-+HttpOnly, can't be planted; the browser overwrites it), just a lingering server-side row. Now documented on both.The proper fix (option 1: seal the session id into the flow at
/start, addpresented_session_idtoLogin, revoke by id when the cookie is absent) changesauth-core's public API and spans the flow-sealing, so I left it as a scoped follow-up on #36 rather than bodge it here. Doc-only;factory0-auth-corebuilds.🤖 Generated with Claude Code