Skip to content

Enchantment pricing, feature toggles, config migration, and worth/GUI fixes - #20

Merged
Faboit1 merged 1 commit into
mainfrom
claude/item-worth-display-bugs-1hrf2y
Aug 14, 2026
Merged

Enchantment pricing, feature toggles, config migration, and worth/GUI fixes#20
Faboit1 merged 1 commit into
mainfrom
claude/item-worth-display-bugs-1hrf2y

Conversation

@Faboit1

@Faboit1 Faboit1 commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

A batch of new features and bug fixes for SellPlugin.

Selling & pricing

  • Enchantment-aware pricing. An item's price now adds each enchantment's configured value (× its level) to the base price, then multiplies the total by a factor (default 1.1x) for every distinct enchantment on the item. Fully configurable under the new enchantments config section, with per-enchantment value overrides. Applied everywhere items are valued or sold, including items placed in the /sell GUI and items inside shulker boxes.
  • Fix uncoloured shulker box selling. SHULKER_BOX (the plain one) doesn't end in _SHULKER_BOX, so its contents were being skipped. Now handled like every coloured variant.
  • Removed the daily sell-multiplier feature entirelyDailyBonusManager and all of its GUI and config references are gone.

Feature toggles

  • New features config section lets you switch off: multipliers, enchantment pricing, shulker selling, the progress GUI (/sellmulti), the leaderboard (/topsell), and the action-bar pop-up. Commands for a disabled feature reply with a configurable message.

Worth display

  • The worth line now stays on items in the player's own inventory while a custom GUI is open (only the GUI's own slots are left undecorated), and stays visible while an item is held on the cursor and put back down.
  • Creative-mode fix. The worth line is now hidden from creative players by default, since their client echoes item lore back to the server and bakes the line into the real item (causing duplicates). Re-enable with worth.show-in-creative if you accept that trade-off.

GUI fixes

  • The /sell GUI sell value now updates on shift-click and drag, not only after picking an item up and replacing it.
  • Fixed a /sellworth crash on block-only materials (e.g. ACACIA_WALL_HANGING_SIGN) — non-item materials now fall back to a barrier icon instead of throwing.

Config

  • Added config-version and an auto-migrator: on startup, if the on-disk config is an older version (or has no version), it makes a timestamped backup, adds any missing options, drops obsolete ones, and stamps the new version.

Notes

  • Bumped plugin version to 2.3.0.
  • Build validation relies on CI (the Maven repository is not reachable from the dev sandbox).

🤖 Generated with Claude Code


Generated by Claude Code

…/GUI bugs

Selling & pricing
- Enchantment-aware pricing: an item's price now adds each enchantment's
  configured value (x level) to the base, then multiplies by 1.1x per distinct
  enchantment (all configurable under `enchantments`). Applied everywhere items
  are valued or sold, including inside the /sell GUI and shulker contents.
- Fix selling contents of the uncoloured SHULKER_BOX (its name doesn't end in
  _SHULKER_BOX, so it was skipped).
- Remove the daily sell-multiplier feature entirely (DailyBonusManager and all
  its GUI/config references).

Feature toggles
- New `features` config section to switch off multipliers, enchantment pricing,
  shulker selling, the progress GUI, the leaderboard, and the action bar.
  Commands for disabled features now reply with a configurable message.

Worth display
- Keep the worth line on items in the player's own inventory even while a
  custom GUI is open (only the GUI's own slots are left undecorated), and keep
  it visible while an item is held on the cursor and put back (refresh on click).
- Hide the worth line from creative-mode players by default to stop the client
  baking it into real items; toggle via `worth.show-in-creative`.

GUI fixes
- /sell GUI sell value now updates on shift-click and drag, not only on
  pick-up-and-replace.
- Fix /sellworth crash on block-only materials (e.g. ACACIA_WALL_HANGING_SIGN)
  by falling back to BARRIER for any non-item material.

Config
- Add `config-version` and an auto-migrator that backs up the existing config
  (timestamped) before adding any missing options and dropping obsolete ones.
  Runs automatically when the on-disk version is older or missing.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016mt4AzbsKNLtCpekgmSGGU
@Faboit1
Faboit1 marked this pull request as ready for review August 14, 2026 09:50
@Faboit1
Faboit1 merged commit c9596b5 into main Aug 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants