Enchantment pricing, feature toggles, config migration, and worth/GUI fixes - #20
Merged
Merged
Conversation
…/GUI bugs Selling & pricing - Enchantment-aware pricing: an item's price now adds each enchantment's configured value (x level) to the base, then multiplies by 1.1x per distinct enchantment (all configurable under `enchantments`). Applied everywhere items are valued or sold, including inside the /sell GUI and shulker contents. - Fix selling contents of the uncoloured SHULKER_BOX (its name doesn't end in _SHULKER_BOX, so it was skipped). - Remove the daily sell-multiplier feature entirely (DailyBonusManager and all its GUI/config references). Feature toggles - New `features` config section to switch off multipliers, enchantment pricing, shulker selling, the progress GUI, the leaderboard, and the action bar. Commands for disabled features now reply with a configurable message. Worth display - Keep the worth line on items in the player's own inventory even while a custom GUI is open (only the GUI's own slots are left undecorated), and keep it visible while an item is held on the cursor and put back (refresh on click). - Hide the worth line from creative-mode players by default to stop the client baking it into real items; toggle via `worth.show-in-creative`. GUI fixes - /sell GUI sell value now updates on shift-click and drag, not only on pick-up-and-replace. - Fix /sellworth crash on block-only materials (e.g. ACACIA_WALL_HANGING_SIGN) by falling back to BARRIER for any non-item material. Config - Add `config-version` and an auto-migrator that backs up the existing config (timestamped) before adding any missing options and dropping obsolete ones. Runs automatically when the on-disk version is older or missing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016mt4AzbsKNLtCpekgmSGGU
Faboit1
marked this pull request as ready for review
August 14, 2026 09:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of new features and bug fixes for SellPlugin.
Selling & pricing
1.1x) for every distinct enchantment on the item. Fully configurable under the newenchantmentsconfig section, with per-enchantment value overrides. Applied everywhere items are valued or sold, including items placed in the/sellGUI and items inside shulker boxes.SHULKER_BOX(the plain one) doesn't end in_SHULKER_BOX, so its contents were being skipped. Now handled like every coloured variant.DailyBonusManagerand all of its GUI and config references are gone.Feature toggles
featuresconfig section lets you switch off: multipliers, enchantment pricing, shulker selling, the progress GUI (/sellmulti), the leaderboard (/topsell), and the action-bar pop-up. Commands for a disabled feature reply with a configurable message.Worth display
worth.show-in-creativeif you accept that trade-off.GUI fixes
/sellGUI sell value now updates on shift-click and drag, not only after picking an item up and replacing it./sellworthcrash on block-only materials (e.g.ACACIA_WALL_HANGING_SIGN) — non-item materials now fall back to a barrier icon instead of throwing.Config
config-versionand an auto-migrator: on startup, if the on-disk config is an older version (or has no version), it makes a timestamped backup, adds any missing options, drops obsolete ones, and stamps the new version.Notes
2.3.0.🤖 Generated with Claude Code
Generated by Claude Code