Closed
Fix plain SHULKER_BOX not treated as shulker box, voiding its contents#16
Conversation
Copilot created this pull request from a session on behalf of
Faboit1
June 4, 2026 19:11
View session
Copilot stopped work on behalf of
Faboit1 due to an error
June 9, 2026 18:01
…config auto-generation - Fix POWDER_SNOW to POWDER_SNOW_BUCKET in price.yml (POWDER_SNOW is a block-only material, not a valid item) - Add mat.isItem() safety check in CategoryItemsGUI.resolveItemStack to prevent similar crashes - Skip worth packet decoration for creative mode players to prevent lore getting baked into item NBT - Auto-generate example-config.yml from JAR defaults on startup and reload
Copilot
AI
changed the title
Fix category buttons and worth tooltip persistence
Fix POWDER_SNOW item crash, creative mode worth lore leak, add example-config generation
Jun 9, 2026
Copilot
AI
changed the title
Fix POWDER_SNOW item crash, creative mode worth lore leak, add example-config generation
Fix plain SHULKER_BOX not treated as shulker box, voiding its contents
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-dyed shulker boxes (
SHULKER_BOX) were being sold as a regular item for their flat price while their contents were silently destroyed. Only dyed variants (WHITE_SHULKER_BOX, etc.) were correctly recognized and had their contents sold.Root cause
isShulkerBoxmatched only onendsWith("_SHULKER_BOX"), which excludes the uncoloredSHULKER_BOXmaterial name. It fell through to the normal item-sell path, consumed the slot, and voided everything inside.Fix