Closed
Fix shulker box selling: purple variant undetected, contents wiped on deposit failure#14
Conversation
- Fix isShulkerBox to match SHULKER_BOX (the default purple shulker box
was never recognized because the check used endsWith("_SHULKER_BOX"))
- Fix GUIListener.onClose: clone shulker before selling its contents and
only return the modified box after a successful deposit; on deposit
failure the original clone (full contents intact) is returned instead
- Add README.md with full feature overview, install steps, commands,
permissions, config reference, and build instructions
Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/c172a735-65a5-4363-8864-5b461c4f774b
Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Faboit1
May 20, 2026 05:15
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs prevented shulker box selling from working correctly: the default purple
SHULKER_BOXmaterial was never recognised as a shulker, and contents were stripped from the box before the economy deposit — meaning a failed deposit returned an empty box with no payment.Changes
SellManager.isShulkerBox— extend match to coverSHULKER_BOXin addition to the 16 colour-prefixed variants (*_SHULKER_BOX):GUIListener.onClose— transactional shulker returnsellShulkerContents.returnItemuntil after the deposit resolves.README.md— added; covers features, requirements, install, commands, permissions, config reference, shulker box behaviour, and build instructions.