Claude/item worth display bugs 1hrf2y - #2
Open
Faboit1 wants to merge 62 commits into
Open
Conversation
…ion bar, prefix toggle Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/2c5243c7-1711-496d-9ff0-e572ca0edb4b Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
…add slot warning Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/2c5243c7-1711-496d-9ff0-e572ca0edb4b Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
…ess-bar feat: category shop GUI, multiplier progress bar, item list paging, action-bar sell notifications
Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/dbaae419-894a-4bbb-a2ac-10479b0e5d70 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
feat: DonutSell-style category GUI, title notifications, inventory info panel
…ess GUI, small caps text, cap multiplier at 3.0x Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/ff4b128b-95f8-4cec-937a-f1b24103fcaa Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/ff4b128b-95f8-4cec-937a-f1b24103fcaa Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
Revamp sell menu and category progress GUI
…ultipliers, action bar notifications, reload command, confirm GUI, filler block config Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/8e3a23dc-5bda-41f1-b630-cef094d39113 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
… in ConfirmSellGUI Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/8e3a23dc-5bda-41f1-b630-cef094d39113 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
…ling Rework sell GUI: money-based multipliers, action bar notifications, confirm flow, reload command
Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/551ed5b6-0e9d-4778-944a-4fd132fdc845 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
…ventory on cancel Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/551ed5b6-0e9d-4778-944a-4fd132fdc845 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
…ll-gui Add confirmation step to Sell All GUI
…edundant cast Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/57566108-30b0-4290-8ba7-33d5081073fa Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
Geometric multiplier progression, green money, vertical snake, configurable icons, potion display fix, TopSell leaderboard
…e layout Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/a36616b0-3fbd-4847-a4d1-94449cb113aa Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
…er's described style Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/3a42b40c-6090-4ebf-b73d-db0f615733d6 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
…,38,39,30,21,12,13 pattern Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/9f5517d5-595a-4798-9793-09ee9c000e26 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
…pacing Fix progress GUI milestones being visually squished together
Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/e79700d3-2f08-4f50-abe1-4813797e9513 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
Shift progress GUI path to start at slot 10 (row 1)
Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/69e46b57-64fa-4349-a212-04e3fbde9446 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
…rmat consistency Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/69e46b57-64fa-4349-a212-04e3fbde9446 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
…e-ui feat: compact number display, daily category bonuses, improved GUI polish
Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/d2e86747-90d4-435e-a8e9-1c8a2293731a Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
fix: exclude armor slots from sellall
Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/98969827-3081-4f78-9905-9d9fc73e4239 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
Add shulker box sell support
…java Agent-Logs-Url: https://github.com/Faboit1/sell-plugin/sessions/c0bffc1c-46b8-4cdf-a08b-3649d9cfead0 Co-authored-by: Faboit1 <177459774+Faboit1@users.noreply.github.com>
Fix missing SellManager import causing build failure
fix: resolve WorthPacketListener compilation failure due to field shadowing in anonymous class
- /sell is now a clean 6-row inventory with Sell button (lime glass pane) in bottom-right corner showing sell value on hover. Close-to-sell still works. - /sellmulti opens a 1x9 GUI showing all category multipliers - /sellworth (aliases: /worth, /prices) opens a paginated item prices browser with category filter cycling - All new text, materials, and settings are fully configurable in config.yml - Category progress/items GUIs now navigate back to /sellmulti instead of /sell
Revamp /sell GUI, add /sellmulti and /sellworth commands
The worth line is applied purely via outgoing item packets, which caused two issues: - Items received while a non-decoratable inventory was open (server shop purchases, /give while a menu is open, pickups) stayed bare until the next full inventory resend, i.e. a relog. Added WorthRefreshListener, which re-sends the player's inventory on the next tick after pickups, inventory closes, and join so the packet listener can decorate them without requiring a rejoin. - In creative mode the client echoes displayed items back to the server (SET_CREATIVE_SLOT), baking the injected worth line into the real item and producing duplicate lines on the next decoration. The injected line now carries an invisible marker; an inbound SET_CREATIVE_SLOT listener strips it before the server stores the item, and decoration always removes any pre-existing worth line before re-adding one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016mt4AzbsKNLtCpekgmSGGU
…rf2y Fix worth line duplication and visibility in creative mode
Creative clients echo lore back via SET_CREATIVE_SLOT, and Minecraft can prepend a formatting code (e.g. §f) to each lore line on serialization. That broke the startsWith() marker check, so the injected worth line was neither stripped on the inbound packet nor de-duplicated on redraw, causing it to bake into the real item and show duplicates on close/reopen. Detect the marker anywhere in the line (contains) for both stripping and de-dup, and treat formatting-only lines as blank separators. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016mt4AzbsKNLtCpekgmSGGU
/showworth [true|false] lets each player show or hide the worth tooltip for themselves (no arg toggles). The preference persists in worth-visibility.yml and the packet decorator now gates on it per-viewer; the view refreshes immediately on change. Folia: declare folia-supported and route every scheduled task through a new Scheduler helper that uses the region/entity/global/async schedulers (part of the Paper API, so the same code runs on Paper too). The three global-scheduler calls that would throw on Folia — inventory-refresh nudge, sell-button refresh, and staggered leaderboard heads — now run on the owning player's region thread; visibility saves run on the async scheduler. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016mt4AzbsKNLtCpekgmSGGU
…rf2y Add /showworth toggle, Folia support, and creative worth-baking fix
…/GUI bugs Selling & pricing - Enchantment-aware pricing: an item's price now adds each enchantment's configured value (x level) to the base, then multiplies by 1.1x per distinct enchantment (all configurable under `enchantments`). Applied everywhere items are valued or sold, including inside the /sell GUI and shulker contents. - Fix selling contents of the uncoloured SHULKER_BOX (its name doesn't end in _SHULKER_BOX, so it was skipped). - Remove the daily sell-multiplier feature entirely (DailyBonusManager and all its GUI/config references). Feature toggles - New `features` config section to switch off multipliers, enchantment pricing, shulker selling, the progress GUI, the leaderboard, and the action bar. Commands for disabled features now reply with a configurable message. Worth display - Keep the worth line on items in the player's own inventory even while a custom GUI is open (only the GUI's own slots are left undecorated), and keep it visible while an item is held on the cursor and put back (refresh on click). - Hide the worth line from creative-mode players by default to stop the client baking it into real items; toggle via `worth.show-in-creative`. GUI fixes - /sell GUI sell value now updates on shift-click and drag, not only on pick-up-and-replace. - Fix /sellworth crash on block-only materials (e.g. ACACIA_WALL_HANGING_SIGN) by falling back to BARRIER for any non-item material. Config - Add `config-version` and an auto-migrator that backs up the existing config (timestamped) before adding any missing options and dropping obsolete ones. Runs automatically when the on-disk version is older or missing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016mt4AzbsKNLtCpekgmSGGU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.