fix(#31,#34): surface sync failures — no false ✓ on LLM error, error in apc status - #59
Open
forge-fz2000 wants to merge 2 commits into
Open
forge-fz2000 wants to merge 2 commits into
forge-fz2000 wants to merge 2 commits into
Conversation
…status in apc status Issue #31: apply_memory_via_llm() now returns -1 (not 0) when the LLM call fails. Callers (sync_memory, sync_all) detect the -1 signal and show an error line instead of a ✓ success indicator, and save the manifest with last_sync_result='error' so the failure is persisted. Issue #34: ToolManifest gains save_failure(msg) which writes last_sync_result='error' to disk. sync_all() calls save_failure() in the except handler so that even a hard crash (e.g. [Errno 17] symlink) is reflected in the next apc status check. _tool_sync_status() in status.py returns 'error' when last_sync_result=='error', displayed as '✗ error' in the tools table. Tests updated to expect -1 from apply_memory_via_llm on LLM failure.
FZ2000
requested changes
Mar 8, 2026
FZ2000
left a comment
FZ2000
left a comment
Owner
There was a problem hiding this comment.
There should be a docker test for this.
FZ2000
approved these changes
Mar 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
Fixes #34
What changed
#31 — Misleading ✓ on LLM memory failure:
apply_memory_via_llm()now returns-1(instead of0) when the LLM call fails-1signal and show✗ errorinstead of✓ N memory fileslast_sync_result='error'#34 — apc status shows synced after crash:
ToolManifestgainssave_failure(msg)which writeslast_sync_result='error'to disksync_all()callssave_failure()in theexcepthandler so hard crashes are recorded_tool_sync_status()instatus.pyreturns'error'whenlast_sync_result=='error'tools_status_table()renders✗ errorin red for failed toolsTests
Updated three test assertions that expected
0on LLM failure; they now expect-1.