Skip to content

Fix native Candidate wheelhouse gates - #78

Merged
houlianpi merged 2 commits into
feature/agent-integration-v3from
fix/76-candidate-wheelhouse-ci
Nov 12, 2026
Merged

houlianpi merged 2 commits into
feature/agent-integration-v3from
fix/76-candidate-wheelhouse-ci

Conversation

@houlianpi

Copy link
Copy Markdown

Requirement

Follow-up for #76 after integration Quality Gates run 43124632097.

User-visible result

The exact macOS 15 arm64 and Windows x64 Candidate wheelhouse jobs can consume the same-run base artifact and enforce compatible native host selection.

Scope

  • Pass the Candidate commit through shell-portable GitHub expressions on Windows and POSIX.
  • Bind the macOS wheel tag set to deployment version 15.0.
  • Reject macOS older than 15 before acquisition or offline installation.
  • Align prompt, tests, and technical documentation.

Non-goals

  • No target expansion, public release change, publication, or main merge.

Interface changes

The darwin-arm64-py311 target manifest records deployment_version: 15.0; host selection requires macOS 15 or newer.

Acceptance scenarios

Given the exact Candidate jobs run on macOS 15 and Windows
When target wheelhouses are acquired
Then valid platform wheels pass compatibility verification
And the exact commit is identical across PowerShell and POSIX jobs
And macOS 14 is rejected before installation

Verification evidence

Check Result Evidence
Targeted tests Pass 98 passed in 7.40s
Build/type checks Pass Python compile, workflow YAML parse, git diff --check
Clean-environment smoke test Pending CI This PR reruns the exact native jobs
Independent review Pass Combined correctness/security reviewer approved the remediation

Agent roles and review gate

Security review

  • Secrets and sensitive inputs are not written to logs, generated code, or tracked configuration.
  • File writes are scoped and atomic.
  • Command/process inputs are not shell-interpolated.
  • Package downloads and remote instructions are pinned or verified.
  • Not security-sensitive; explanation: security-sensitive fix independently reviewed.

Compatibility impact

macOS target is explicitly 15.0 or newer; Windows target remains x64 / CPython 3.12.

Rollback

Revert commit 163bf67 and keep #76 blocked.

Known limitations

  • Main remains gated by epic-level black-box acceptance.

Definition of Done

  • The issue met Definition of Ready before implementation began.
  • Scope and non-goals were preserved.
  • All acceptance scenarios pass in their required environments; clean-environment evidence is present when the issue or release gate requires it.
  • Required CI checks pass.
  • One independent reviewer approved the change.
  • A separate acceptor posted clean-environment evidence when the issue or release gate requires it; otherwise marked not required with a reason.
  • Security coverage passed or is explicitly not applicable; correctness and security may be covered by the same qualified independent reviewer.
  • Prompt changes include an eval comparison.
  • Documentation and machine-readable configuration agree.

@houlianpi

Copy link
Copy Markdown
Author

Independent combined correctness/security review: APPROVED for the final commit c264415. The Windows-only test portability follow-up sets repository-local core.longpaths=true before indexing the temporary clean source repository; product behavior and global Git configuration are unchanged. Local focused evidence: 36 Candidate wheelhouse tests pass; diff check passes. Updated Quality Gates run 43127057871 and Agent Contract run 43127057817 are in progress.

@houlianpi
houlianpi merged commit fdaac41 into feature/agent-integration-v3 Nov 12, 2026
32 checks passed
@houlianpi
houlianpi deleted the fix/76-candidate-wheelhouse-ci branch November 12, 2026 00:29
@houlianpi houlianpi mentioned this pull request Nov 12, 2026
9 of 13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant