-
Notifications
You must be signed in to change notification settings - Fork 0
Rt cancel #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Rt cancel #109
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b123f24
added stop all command + other things needed for it to function
RoRoBout212 cfe717b
made stop all sequential instead of parallel
RoRoBout212 75a453f
started creating encoders for the stop command, need to find if we ne…
RoRoBout212 9698c24
fixed encoder issues to allow for climber reset encoder command to work
RoRoBout212 b358474
started testing in simulation: need to find how to fix climber reset …
RoRoBout212 3e1de9d
removed encoder reset for climber
RoRoBout212 430742d
continued testing (committed to do a pull from main)
RoRoBout212 df42bfb
pulled from main
RoRoBout212 cdf59c1
finished testing in sim made adjustments based to reset all based on …
RoRoBout212 8fb2677
started testing as parallel
RoRoBout212 64d6afe
Merge branch 'main' of https://github.com/FRC4048/Java_2026 into RT-C…
RoRoBout212 3493523
finsihed testing in sim and finalized what reset all command will loo…
RoRoBout212 630c589
started testing on robot
RoRoBout212 4e7949a
Merge branch 'main' into RT-Cancel
Sahiltheram 1dd39ba
added auto
Sahiltheram 2128889
Testing reset all and fixing errors
Sahiltheram 4638469
made changes based on comments
RoRoBout212 80052d7
Merge branch 'main' of https://github.com/FRC4048/Java_2026 into RT-C…
RoRoBout212 2b46d88
started to fix reset all with new intake deploying command. Need to f…
RoRoBout212 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 0 additions & 41 deletions
41
src/main/java/frc/robot/commands/intakeDeployment/RunDeployer.java
This file was deleted.
Oops, something went wrong.
37 changes: 0 additions & 37 deletions
37
src/main/java/frc/robot/commands/intakeDeployment/SetDeploymentState.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package frc.robot.commands.sequences; | ||
|
|
||
| import frc.robot.commands.angler.StowAngler; | ||
| import frc.robot.commands.climber.ClimberDown; | ||
| import frc.robot.commands.intakeDeployment.ToggleDeployment; | ||
| import frc.robot.commands.shooter.SetShootingState; | ||
| import frc.robot.commands.turret.RunTurretToRevLimit; | ||
| import frc.robot.constants.Constants; | ||
| import frc.robot.constants.enums.DeploymentState; | ||
| import frc.robot.constants.enums.ShootingState; | ||
| import frc.robot.constants.enums.ShootingState.ShootState; | ||
| import frc.robot.subsystems.AnglerSubsystem; | ||
| import frc.robot.subsystems.ClimberSubsystem; | ||
| import frc.robot.subsystems.FeederSubsystem; | ||
| import frc.robot.subsystems.HopperSubsystem; | ||
| import frc.robot.subsystems.IntakeDeployerSubsystem; | ||
| import frc.robot.subsystems.IntakeSubsystem; | ||
| import frc.robot.subsystems.ShooterSubsystem; | ||
| import frc.robot.subsystems.TurretSubsystem; | ||
| import frc.robot.utils.logging.commands.LoggableParallelCommandGroup; | ||
| import frc.robot.utils.logging.commands.LoggableSequentialCommandGroup; | ||
|
|
||
| public class ResetAll extends LoggableSequentialCommandGroup { | ||
| public ResetAll(AnglerSubsystem anglerSubsystem, ClimberSubsystem climberSubsystem, | ||
| FeederSubsystem feederSubsystem, HopperSubsystem hopperSubsystem, | ||
| IntakeDeployerSubsystem intakeDeployerSubsystem, IntakeSubsystem intakeSubsystem, | ||
| ShooterSubsystem shooterSubsystem, TurretSubsystem turretSubsystem, ShootingState shootState) { | ||
|
|
||
| super( | ||
| DeploymentState deploymentState = intakeDeployerSubsystem.getDeploymentState(); | ||
| if(deploymentState == DeploymentState.DOWN) | ||
| new ToggleDeployment(intakeDeployerSubsystem); | ||
| new LoggableParallelCommandGroup( | ||
| new StowAngler(anglerSubsystem), | ||
| new ClimberDown(climberSubsystem), | ||
| new SetShootingState(shootState, ShootState.STOPPED), | ||
| new RunTurretToRevLimit(turretSubsystem) | ||
| ) | ||
| ); | ||
| } | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is incorrect, it has to be stowAngler. the same is true for all the autonomous commands. I'm not sure why this was even changed in this PR, it shouldn't be part of it. This will create conflicts to Michael who is working on the autonomous commands.
I think it would be best to not rename back StowAngler to RunAnglerToReverseLimit and undo all the changes that are related to this.