Skip to content

Key catalogue releases by version and preserve history - #8

Merged
admdly merged 3 commits into
mainfrom
fix-publisher-release-tag
Nov 4, 2026
Merged

admdly merged 3 commits into
mainfrom
fix-publisher-release-tag

Conversation

@admdly

@admdly admdly commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

The publisher sent the git tag (branding-v0.8.9) as the release tag, but that field is the semver key the whole stack compares on: the API partitions non-semver tags out of ordering, the site's semver gt/lt throws on them, its edit form derives version from tag, and core's updater takes the first release as latest. Send the plain version instead; the git tag stays reachable via changelog and download URLs.

Also prepends to the published release history (fetched with the machine token, now passed to the build step) instead of submitting only the newest entry. Same-tag re-runs replace in place, capped at the schema's 100, unknown future fields stripped, and any non-404 fetch failure fails the build loudly rather than silently wiping history.

Send the plain semver version as the release tag instead of the git tag: the API and site sort and compare releases by semver tag, and the site derives the editable version from it. Prepend to the published release history (same-tag re-runs replace in place, capped at 100) instead of submitting only the newest entry.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T01:36:32.081619Z 7aee2ea Manual request
🔒 Security Review ✅ Completed 2026-11-04T01:29:41.836050Z b43f149 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@admdly admdly self-assigned this Nov 4, 2026
@admdly

This comment was marked as low quality.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b43f149753

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/scripts/build_payload.py Resolved
A pre-fix entry keyed by git tag counts as the same release as its version, so re-publishing replaces the twin instead of doubling it. Non-matching legacy entries are preserved.
@admdly

This comment was marked as low quality.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 7aee2eaefb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@admdly
admdly merged commit 856a4fa into main Nov 4, 2026
3 checks passed
@admdly
admdly deleted the fix-publisher-release-tag branch November 4, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant