Skip to content

Use the /v2 namespace for module publishing #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
admdly wants to merge 1 commit into from
Closed

Use the /v2 namespace for module publishing #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/scripts/test_publish_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def run_submit(self, exists, replies, step="Submit revision (create or update)",
print(json.dumps(response['body']) + '\\n' + str(response['code']))
''')
curl.chmod(0o755)
env = {**os.environ, "PATH": f"{root}:{os.environ['PATH']}", "API_BASE_URL": "https://api.example.test/extensions/v2", "API_TOKEN": "offline", "EXT_ID": "example", "REVISION_ID": "revision", "GITHUB_OUTPUT": str(root / "outputs")}
env = {**os.environ, "PATH": f"{root}:{os.environ['PATH']}", "API_BASE_URL": "https://api.example.test/v2", "API_TOKEN": "offline", "EXT_ID": "example", "REVISION_ID": "revision", "GITHUB_OUTPUT": str(root / "outputs")}
if hostile_module and after_api:
env.update({"HOSTILE_MODULE": hostile_module, "HOSTILE_SOURCE": hostile_source})
result = subprocess.run(["bash", "-e", "-o", "pipefail", "-c", workflow_run(step)], cwd=root, env=env, capture_output=True, text=True)
Expand Down Expand Up @@ -131,7 +131,7 @@ def test_explicit_machine_approval_matches_the_merged_api(self):
for code in [200, 403, 409]:
result, calls, _ = self.run_submit(True, [{"method": "POST", "code": code, "body": {"result": {"status": "approved"}}}], step="Approve revision")
self.assertEqual(result.returncode == 0, code == 200, result.stderr)
self.assertEqual(calls, ["POST https://api.example.test/extensions/v2/extensions/example/revisions/revision/approve?notify=false"])
self.assertEqual(calls, ["POST https://api.example.test/v2/extensions/example/revisions/revision/approve?notify=false"])

def test_retries_preserve_update_method_and_payload(self):
result, calls, _ = self.run_submit(True, [{"method": "PUT", "code": 429, "body": {}}, {"method": "PUT", "code": 202, "body": {"result": {"revision_id": "revision", "status": "pending"}}}])
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ permissions:

env:
AUTH_TOKEN_URL: https://auth.fossbilling.net/oauth2/token
API_BASE_URL: https://api.fossbilling.net/extensions/v2
API_BASE_URL: https://api.fossbilling.net/v2
API_AUDIENCE: https://api.fossbilling.net

jobs:
Expand Down
Loading