Repository navigation
Fix useless assignment in moderation notify - #320
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Auto-approved: Refactor removes a useless initializer by assigning developerId explicitly in each branch; assigned values match the previous initial value, so behavior is unchanged and the CodeQL warning is resolved.
Turn on auto-fix | Re-trigger cubic
admdly
force-pushed
the
fix/notify-useless-assignment
branch
from
November 14, 2026 11:00
bff08a8 to
394be58
Compare
Deploying Preview to Cloudflare (api)Preview URL: https://fix-notify-useless-assignment-api.fossbilling.workers.dev/ (commit
|
| Status | Deployment URL | Commit | Updated (UTC) | Details |
|---|---|---|---|---|
| Build: Success ✅ Deployment: Success ✅ |
https://6ee8beea-api.fossbilling.workers.dev/ | 394be58 |
2026-11-14T11:03:16.997Z | View logs ↗ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses CodeQL "Useless assignment to local variable" in src/services/extensions/v2/email/notify.ts:39.
developerIdwithout initializer to match surroundinglet to / extensionName / developerNamestyle.input.developerId, extension path usesrecipient.developerId).buildModerationEmail.