Skip to content

Match deployment Node version to API build jobs - #317

Merged
admdly merged 2 commits into
mainfrom
codex/api-deployment-node
Nov 13, 2026
Merged

admdly merged 2 commits into
mainfrom
codex/api-deployment-node

Conversation

@admdly

@admdly admdly commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

API deployment jobs inherited Node 22 from the runner while build and test jobs use Node 26.13.1 and the repository requires Node 24 or later. Wrangler installation consequently emitted EBADENGINE.

Pin the merged shared workflow from FOSSBilling/.workflows#39 and select Node 26.13.1 for both preview and production deployment jobs. Keep the Cloudflare event workflow on the same shared-workflow revision.

@admdly
admdly marked this pull request as ready for review November 13, 2026 00:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-13T00:49:08.103984Z 286bbe7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@admdly admdly self-assigned this Nov 13, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Requires human review: Bumps shared workflow pins and sets Node 26.13.1 for preview/production deploy jobs to fix EBADENGINE during Wrangler install. Production deployment config changes and the external workflow revision's content are unverified, so human sign-off is needed.

Turn on auto-fix | Re-trigger cubic

@github-actions

Copy link
Copy Markdown

Deploying Preview to Cloudflare (api)

Preview URL: https://codex-api-deployment-node-api.fossbilling.workers.dev/ (commit 286bbe7)

This URL reflects your latest successful Preview deployment.

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) Details
Build: Success ✅
Deployment: Success ✅
https://7671841e-api.fossbilling.workers.dev/ 286bbe7 2026-11-13T00:47:38.630Z View logs ↗

@admdly
admdly merged commit c543fdb into main Nov 13, 2026
23 checks passed
@admdly
admdly deleted the codex/api-deployment-node branch November 13, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant