Repository navigation
Replace aws4fetch with owned SigV4 signer - #312
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
api | 7a023a5 | Nov 10 2026, 05:51 AM |
admdly
force-pushed
the
codex/directory-package-builds
branch
from
November 10, 2026 05:48
244a19d to
25bb85c
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the unmaintained
aws4fetchdependency (last published Aug 2024) in favor of a minimal owned SigV4 signer (src/lib/adapters/b2/sigv4.ts, ~130 lines,crypto.subtleonly, zero deps, Workers + Node compatible).package-store.tssigns viasignS3Request()with identical behavior (path-style URLs,redirect: manual, 15s timeout,versionIddelete flow); PUT reuses the caller checksum as payload hash so bodies are not rehashed.sigv4.node.test.ts: fixed-date GET cross-checked against an independent Node-crypto recomputation, PUT metadata-header signing,versionIdbound to signature.