Skip to content

Separate directory record IDs from public identifiers - #309

Merged
admdly merged 4 commits into
mainfrom
codex/directory-identity
Nov 7, 2026
Merged

admdly merged 4 commits into
mainfrom
codex/directory-identity

Conversation

@admdly

@admdly admdly commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Extension and developer records currently use their public identifiers as database keys. Generate UUIDv7 IDs for record identity, keep public names in identifier, and use UUIDs for ownership, revisions, claims and publisher bindings. Public URLs and manifest IDs continue to use identifiers.

Migration 0030_directory_identity preserves existing records, ownership, review history and resource accounting. This PR also removes ambiguous ID fallbacks and tests that internal UUIDs cannot be used as public profile identifiers.

Coordinate deployment with the caller updates:

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-07T17:29:07.289682Z 9191161 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
api d846c48 Nov 07 2026, 05:54 PM

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 48 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread src/services/extensions/v2/README.md Resolved
@admdly admdly self-assigned this Nov 7, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 20 files (changes from recent commits).

Requires human review: Adds UUIDv7 internal IDs with a schema/data migration (0030) that rebuilds directory tables, and changes public API request/response contracts (identifier vs id); the migration and contract changes need human sign-off.

Turn on auto-fix | Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Requires human review: Adds UUIDv7 internal IDs via DB migration 0030 (rebuilds directory tables) and changes public API request/response contracts (identifier vs id); the migration and contract changes need human sign-off.

Turn on auto-fix | Re-trigger cubic

@admdly
admdly merged commit d0d8cbd into main Nov 7, 2026
9 checks passed
@admdly
admdly deleted the codex/directory-identity branch November 7, 2026 18:00
admdly added a commit to FOSSBilling/modules that referenced this pull request Nov 7, 2026
Send the manifest's public extension ID as `identifier` in directory
creation requests. Keep the manifest ID and update paths as public
identifiers, and update the publishing regressions and setup notes for
UUID-based developer bindings.

Companion API change: FOSSBilling/api#309. Merge
alongside the API contract update before running the publisher.
Directory caller update:
FOSSBilling/extensions#416. Package publishing
continues separately in #12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant