Skip to content

Fix manifest migration for existing extension releases - #296

Merged
admdly merged 3 commits into
mainfrom
codex/fix-manifest-migration
Nov 5, 2026
Merged

admdly merged 3 commits into
mainfrom
codex/fix-manifest-migration

Conversation

@admdly

@admdly admdly commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Production deployment stops at migration 0029 because all 45 existing releases lack the new requirements object. Convert their recorded FOSSBilling minimums to lower-bound constraints and make PHP optional: omission inherits the installed FOSSBilling version’s runtime requirements; an explicit constraint adds a restriction.

Preserve existing constraints and carry verified PHP requirements from the BTCPay 0.1.3–0.1.5 and OpenReceive 0.4.29 packages. Invalid supplied PHP values still fail validation. Migration rollback, audit history, and resource accounting remain covered.

Includes the previously failed migration because it rolled back in production. The directory companion is in FOSSBilling/extensions#407; deploy the API fix first.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-05T13:00:47.821096Z 8bdccc5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
api 9d222b4 Nov 05 2026, 03:38 PM

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 4 files (changes from recent commits).

Requires human review: Fix for failed manifest migration 0029: legacy minimums become lower-bound constraints, PHP optional with runtime-inheritance semantics, plus tests/docs. Decisive issue: missing PHP inherits runtime requirements rather than requiring explicit review.

Turn on auto-fix | Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Requires human review: Migration fix makes requires.php optional with runtime inheritance and converts legacy minimums to lower bounds, changing the v2 publishing contract and production data migration policy; needs human sign-off.

Turn on auto-fix | Re-trigger cubic

@admdly
admdly merged commit 7d53540 into main Nov 5, 2026
9 checks passed
@admdly
admdly deleted the codex/fix-manifest-migration branch November 5, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant