Skip to content

Allow owners to update pending extension submissions - #295

Merged
admdly merged 5 commits into
mainfrom
codex/edit-pending-submissions
Nov 5, 2026
Merged

admdly merged 5 commits into
mainfrom
codex/edit-pending-submissions

Conversation

@admdly

@admdly admdly commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Owners can update a pending extension submission instead of waiting for a review decision. Add PUT /extensions/{id}/revisions/{revisionId}, accepting the full manifest-compatible content body and returning a fresh pending revision ID.

Replacement is atomic and restricted to the active owner at the current ownership epoch. The published listing and reviewed history stay unchanged. Rotating the ID rejects stale owner edits and stale moderator decisions; failed insertion or write admission restores the original pending revision. The endpoint uses the existing content validation, request bounds, and rate limits.

Companion UI: FOSSBilling/extensions#407. Deploy this endpoint before the extensions UI's pending-update feature. This PR adds no migrations or bindings.

Replace pending submissions atomically with a fresh revision identity, preserving published content and rejecting stale edits and review actions. Cover concurrency, rollback, ownership, validation, and rate admission.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
api da0094f Nov 05 2026, 12:02 PM

@admdly
admdly marked this pull request as ready for review November 4, 2026 07:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-04T07:42:23.821885Z 00bd012 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread src/services/extensions/v2/README.md Resolved
@admdly admdly self-assigned this Nov 5, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 4 files (changes from recent commits).

Requires human review: Adds a new owner-only PUT endpoint to replace pending extension revisions, with tests and README updates. This expands the public API surface and changes pending-revision ownership/attribution policy, so a human should decide whether this is the intended contract.

Turn on auto-fix | Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Requires human review: Adds a new owner-only PUT endpoint for replacing pending extension revisions and reworks documentation. The docs issue was fixed, but this still expands the public API surface and changes pending-revision attribution and moderation semantics, which need human approval.

Turn on auto-fix | Re-trigger cubic

@admdly
admdly merged commit 8e2abed into main Nov 5, 2026
9 checks passed
@admdly
admdly deleted the codex/edit-pending-submissions branch November 5, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant