feat: #276 차록 작성 별점 슬라이더 개선#284
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Walkthrough평점 입력 시스템을 재설계합니다. AxisStarRow를 슬라이더 기반에서 포인터 드래그 방식으로 전환하고, displayMultiplier prop을 도입하여 5점/10점 스케일 토글을 지원합니다. 여러 페이지에서 StarRating을 AxisStarRow로 대체합니다. Changes
Sequence DiagramsequenceDiagram
participant User
participant Page as BlindNoteWrite/<br/>NewNote
participant AxisRatingSection
participant AxisStarRow
User->>Page: 스케일 버튼 클릭 (5점/10점)
activate Page
Page->>Page: scale 상태 업데이트
Page->>AxisRatingSection: displayMultiplier 재전달
deactivate Page
activate AxisRatingSection
AxisRatingSection->>AxisStarRow: displayMultiplier 및 값 전달
deactivate AxisRatingSection
User->>AxisStarRow: 별점 영역 드래그
activate AxisStarRow
AxisStarRow->>AxisStarRow: onPointerMove: valueFromPointer 계산
AxisStarRow->>AxisStarRow: snapToStep으로 0.25 단위 스냅
AxisStarRow->>AxisStarRow: displayMultiplier로 표시값 계산
AxisStarRow->>AxisStarRow: onChange 콜백 호출
deactivate AxisStarRow
AxisStarRow->>Page: 값 업데이트
activate Page
Page->>Page: 폼 상태 동기화
deactivate Page
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes AxisStarRow의 포인터 드래그 상호작용 로직(이벤트 핸들러, 좌표 계산, 스냅핑)이 밀도 높고, displayMultiplier prop 도입으로 인한 계산 경로 변경이 있으며, 여러 페이지의 통합 로직 변경으로 이질적인 수정이 산재되어 있습니다. Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by CodeRabbit
릴리스 노트
새로운 기능
개선 사항