feat: #279 다구 관리 + 차록 연동#283
Open
FLYLIKEB wants to merge 2 commits into
Open
Conversation
- Teaware 엔티티/DTO/서비스/컨트롤러/모듈 신규 생성 - TypeORM migration: CreateTeaware, AddTeawareIdToNotes - CRUD + pin 토글 API (JWT 인증) - E2E 테스트 6건 추가 (POST/GET/PATCH/DELETE/pin/401) - 프론트엔드: Teaware 타입, teawareApi, TeawareSection 컴포넌트 - Settings 다구 관리 UI, NewNote 다구 선택, NoteDetail 다구 표시 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Note.teaware ManyToOne에 onDelete: 'SET NULL' 추가 (migration과 일치) - CreateTeawareDto.memo에 @maxlength(500) 추가 - CreateNoteDto.teawareId @IsNumber → @ISINT @ispositive로 수정 - TeawareService.remove 반환 타입 Promise<Teaware> → Promise<void> - 다른 사용자 다구 접근 시 404 E2E 격리 테스트 추가 - NewNote.tsx 핀 표시 이모지 → [핀] 텍스트로 변경 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Walkthrough이 PR은 다구(차 도구) 관리 기능을 추가합니다. 백엔드에 Teaware 엔티티, CRUD 서비스 및 REST 컨트롤러를 구현하고, 프론트엔드에 관리 UI 컴포넌트와 API를 추가합니다. Note 엔티티에 teawareId 관계를 통합하며, 포괄적인 E2E 테스트를 포함합니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User as 사용자 (Client)
participant Browser as Browser
participant Server as NestJS Server
participant DB as Database
User->>Browser: 설정에서 다구 추가 버튼 클릭
Browser->>Browser: TeawareSection 렌더링<br/>fetchTeawares() 호출
Browser->>Server: GET /teaware (JWT)
Server->>DB: SELECT * FROM teaware WHERE userId = ?
DB-->>Server: 다구 목록
Server-->>Browser: [Teaware[]]
Browser->>Browser: 상태 업데이트, 목록 표시
User->>Browser: "추가" 버튼 클릭
Browser->>Browser: Dialog 열기, 폼 초기화
User->>Browser: 폼 입력 (이름, 카테고리, 용량 등)
User->>Browser: "추가" 버튼 클릭
Browser->>Server: POST /teaware<br/>{name, category, capacity, ...}
Server->>DB: INSERT INTO teaware (userId, name, ...)<br/>VALUES (?, ?, ...)
DB-->>Server: 생성된 Teaware
Server-->>Browser: {id, name, category, ...}
Browser->>Browser: 목록에 추가, Dialog 닫기<br/>성공 Toast 표시
sequenceDiagram
participant User as 사용자 (Client)
participant Browser as Browser
participant Server as NestJS Server
participant DB as Database
User->>Browser: 차록 작성 페이지 열기
Browser->>Browser: useNoteForm() 초기화
Browser->>Server: GET /teaware (JWT)
Server->>DB: SELECT * FROM teaware<br/>WHERE userId = ? ORDER BY isPinned DESC
DB-->>Server: 핀된 다구 포함 목록
Server-->>Browser: [Teaware[]]
Browser->>Browser: teawares 상태 저장<br/>핀된 다구 자동 선택
User->>Browser: 다구 선택 변경 (Dropdown)
Browser->>Browser: teawareId 상태 업데이트
User->>Browser: 차록 저장 버튼 클릭
Browser->>Server: POST /notes<br/>{content, drinkDate, teawareId, ...}
Server->>DB: INSERT INTO notes<br/>(userId, content, teawareId, ...)<br/>VALUES (?, ?, ?, ...)
DB-->>Server: 생성된 Note
Server-->>Browser: {id, content, teaware: {...}, ...}
Browser->>Browser: 차록 상세 페이지 이동<br/>teaware 정보 표시
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (7)
src/types/index.ts (1)
111-116:category타입을 문자열 유니온으로 좁히는 것을 권장합니다.현재
string은 오타/잘못된 값이 컴파일 단계에서 걸러지지 않습니다. 가능한 카테고리 집합이 정해져 있다면 유니온 타입으로 제한해 타입 안정성을 높이는 편이 좋습니다.♻️ 제안 예시
+export type TeawareCategory = '자사호' | '개완' | '공도배' | '잔'; export interface Teaware { id: number; userId: number; name: string; - category: string; + category: TeawareCategory; capacity?: number | null; material?: string | null; memo?: string | null;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/types/index.ts` around lines 111 - 116, The Teaware interface’s category is currently a plain string which allows typos; define a specific union type (e.g. export type TeawareCategory = 'X' | 'Y' | 'Z' or whatever the real allowed values are) and change Teaware.category to that union (or to TeawareCategory | null if nullable), then update all usages that expect a string (constructors, validators, DB mappers, tests, and any deserialization code) to use/validate the new union type and adjust runtime parsing/validation where input can be arbitrary.backend/test/suites/teaware.e2e-spec.ts (2)
8-8: 미사용 변수teawareIdLine 8에서 선언된
teawareId는 Line 50에서 할당만 되고 이후 사용되지 않습니다. 각 테스트가 독립적으로 데이터를 생성하므로 제거해도 됩니다.♻️ 수정 제안
describe('/teaware - 다구 관리 API', () => { let context: TestContext; let testUser: TestUser; - let teawareId: number;그리고 Line 50도 제거:
expect(response.body.isPinned).toBe(false); - teawareId = response.body.id; });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/test/suites/teaware.e2e-spec.ts` at line 8, Remove the unused variable teawareId: delete the declaration of teawareId and the assignment to teawareId found later in the spec (they're unused after assignment); keep each test creating its own data independently (e.g., leave creation helpers intact) so removing teawareId doesn't change test behavior.
15-19:beforeEach에서 FK 체크 비활성화 주의
SET FOREIGN_KEY_CHECKS = 0은 테스트 격리에 유용하지만, 실제 FK 제약 조건 관련 버그를 감출 수 있습니다. 현재 구조에서는notes테이블과의 관계가 있으므로,notes의teawareId도 함께 정리하는 것이 더 안전할 수 있습니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/test/suites/teaware.e2e-spec.ts` around lines 15 - 19, The test beforeEach currently disables FK checks and only deletes from the teaware table (in the beforeEach block using context.dataSource.query), which can hide FK-related bugs; update the setup to properly clear dependent rows by deleting related rows in the notes table (e.g., remove rows where notes.teawareId references teaware) before deleting teaware, or use a safe cascade/truncate approach within the beforeEach to ensure both notes and teaware are cleared while keeping FK checks enabled.backend/src/teaware/teaware.controller.ts (1)
74-81:parseInt로 이미 숫자인userId파싱JWT 전략에서
req.user.userId는 이미 숫자 타입입니다 (jwt.strategy.tsLine 30-37 참조).parseInt는 불필요하며, 직접 타입 검사가 더 명확합니다.♻️ 타입 안전한 파싱 제안
private parseUserId(req: any): number { - const parsed = parseInt(req.user?.userId, 10); - if (Number.isNaN(parsed)) { + const userId = req.user?.userId; + if (typeof userId !== 'number' || !Number.isFinite(userId)) { throw new BadRequestException('인증 정보가 올바르지 않습니다.'); } - return parsed; + return userId; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/teaware/teaware.controller.ts` around lines 74 - 81, The parseUserId method currently calls parseInt on req.user?.userId which is unnecessary since jwt.strategy populates userId as a number; update parseUserId to perform a direct type and validity check instead: verify req.user?.userId exists and typeof req.user.userId === 'number' and Number.isFinite(req.user.userId'), throw the existing BadRequestException('인증 정보가 올바르지 않습니다.') on failure, and return the numeric userId otherwise (referencing parseUserId and req.user.userId to locate the code).src/components/teaware/TeawareSection.tsx (1)
267-275: 메모 입력maxLength누락이름(
maxLength={100})과 재질(maxLength={100})에는 길이 제한이 있지만, 메모에는 없습니다. 백엔드 DTO는@MaxLength(500)을 적용하고 있어, 프론트엔드에서도 일치시키는 것이 좋습니다.♻️ 수정 제안
<div className="space-y-1.5"> <Label htmlFor="teaware-memo">메모</Label> <Input id="teaware-memo" value={form.memo} onChange={(e) => setForm((prev) => ({ ...prev, memo: e.target.value }))} placeholder="간단한 메모" + maxLength={500} /> </div>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/teaware/TeawareSection.tsx` around lines 267 - 275, The memo Input in TeawareSection is missing a maxLength and should match the backend DTO (`@MaxLength`(500)); update the <Input id="teaware-memo"> used with form.memo to include maxLength={500} and keep the existing placeholder and onChange handler (setForm) unchanged so the UI enforces the same 500-character limit as the server.backend/src/teaware/dto/create-teaware.dto.ts (2)
13-15:name필드에 빈 문자열 검증 누락
@IsString()과@MaxLength(100)만으로는 빈 문자열("")이 통과됩니다.@IsNotEmpty()데코레이터를 추가하여 빈 이름을 방지하는 것이 좋습니다.♻️ 수정 제안
import { IsString, IsEnum, IsOptional, IsNumber, MaxLength, Min, Max, + IsNotEmpty, } from 'class-validator'; export class CreateTeawareDto { `@IsString`() + `@IsNotEmpty`() `@MaxLength`(100) name: string;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/teaware/dto/create-teaware.dto.ts` around lines 13 - 15, The name property in CreateTeawareDto is only validated with `@IsString`() and `@MaxLength`(100) so an empty string passes; add the `@IsNotEmpty`() decorator to the name field and import IsNotEmpty from class-validator to ensure "" is rejected (update the CreateTeawareDto class property `name: string` and the import list accordingly).
20-24: 용량 검증 범위 확인
@Min(1)설정으로 최소 1ml부터 허용되는데, 0ml 용량이 필요한 경우가 있을 수 있습니다(예: 차판처럼 용량 개념이 없는 다구). 현재 설계 의도가 맞다면 무시하셔도 됩니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/src/teaware/dto/create-teaware.dto.ts` around lines 20 - 24, The capacity field in CreateTeawareDto uses `@Min`(1) which disallows 0ml values needed for items without capacity; change the validator to allow zero by replacing `@Min`(1) with `@Min`(0) (or explicitly document/handle null for capacity?: number | null) so capacity can be 0 while keeping `@Max`(9999.9) and other decorators intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/teaware/TeawareSection.tsx`:
- Around line 250-255: The capacity input in TeawareSection uses min={0} which
conflicts with the backend DTO `@Min`(1); update the input to enforce min={1} and
ensure the onChange stores a numeric value (e.g., parseInt/Number) into
form.capacity via setForm so the client-side validation matches the backend
(refer to TeawareSection, the capacity input element, form.capacity and the
setForm updater).
- Around line 124-125: Newly created Teaware is appended to state with
setTeawares([...prev, created]) but server orders by isPinned DESC, createdAt
DESC so the local list becomes unsorted; fix by either (A) after
teawareApi.create(payload) call fetchTeawares() to replace local state with the
server-sorted list, or (B) insert the created item into the correct position
locally using the same comparator (isPinned DESC, createdAt DESC) before calling
setTeawares; locate this logic around teawareApi.create and setTeawares in
TeawareSection (or use the existing fetchTeawares helper) and implement one of
these two approaches so the UI order matches the backend.
In `@src/hooks/useNoteForm.ts`:
- Around line 193-195: The current logic in useNoteForm (around setTeawareId
usage with normalizedNote.teawareId and the payload preparation around line 374)
fails to clear an existing teaware selection because it only sets state when
teawareId != null and converts null to undefined when sending, so the server
never receives a deliberate un-link. Update the initializer that reads
normalizedNote.teawareId to explicitly call setTeawareId(null) when
normalizedNote.teawareId === null (not only when != null), and update the
payload construction (the function that builds the submission payload / submit
handler) to send teawareId: null when clearing instead of omitting it or
converting it to undefined so the server records the removal.
In `@src/lib/api/teaware.api.ts`:
- Line 20: The remove method in src/lib/api/teaware.api.ts is typed to return
Teaware but the backend DELETE /teaware/:id returns { message: string } (see
teaware.controller.ts Line 63); update the generic on apiClient.delete used in
the remove function to reflect the actual response shape ({ message: string })
so the remove method's return type matches the backend.
---
Nitpick comments:
In `@backend/src/teaware/dto/create-teaware.dto.ts`:
- Around line 13-15: The name property in CreateTeawareDto is only validated
with `@IsString`() and `@MaxLength`(100) so an empty string passes; add the
`@IsNotEmpty`() decorator to the name field and import IsNotEmpty from
class-validator to ensure "" is rejected (update the CreateTeawareDto class
property `name: string` and the import list accordingly).
- Around line 20-24: The capacity field in CreateTeawareDto uses `@Min`(1) which
disallows 0ml values needed for items without capacity; change the validator to
allow zero by replacing `@Min`(1) with `@Min`(0) (or explicitly document/handle null
for capacity?: number | null) so capacity can be 0 while keeping `@Max`(9999.9)
and other decorators intact.
In `@backend/src/teaware/teaware.controller.ts`:
- Around line 74-81: The parseUserId method currently calls parseInt on
req.user?.userId which is unnecessary since jwt.strategy populates userId as a
number; update parseUserId to perform a direct type and validity check instead:
verify req.user?.userId exists and typeof req.user.userId === 'number' and
Number.isFinite(req.user.userId'), throw the existing BadRequestException('인증
정보가 올바르지 않습니다.') on failure, and return the numeric userId otherwise
(referencing parseUserId and req.user.userId to locate the code).
In `@backend/test/suites/teaware.e2e-spec.ts`:
- Line 8: Remove the unused variable teawareId: delete the declaration of
teawareId and the assignment to teawareId found later in the spec (they're
unused after assignment); keep each test creating its own data independently
(e.g., leave creation helpers intact) so removing teawareId doesn't change test
behavior.
- Around line 15-19: The test beforeEach currently disables FK checks and only
deletes from the teaware table (in the beforeEach block using
context.dataSource.query), which can hide FK-related bugs; update the setup to
properly clear dependent rows by deleting related rows in the notes table (e.g.,
remove rows where notes.teawareId references teaware) before deleting teaware,
or use a safe cascade/truncate approach within the beforeEach to ensure both
notes and teaware are cleared while keeping FK checks enabled.
In `@src/components/teaware/TeawareSection.tsx`:
- Around line 267-275: The memo Input in TeawareSection is missing a maxLength
and should match the backend DTO (`@MaxLength`(500)); update the <Input
id="teaware-memo"> used with form.memo to include maxLength={500} and keep the
existing placeholder and onChange handler (setForm) unchanged so the UI enforces
the same 500-character limit as the server.
In `@src/types/index.ts`:
- Around line 111-116: The Teaware interface’s category is currently a plain
string which allows typos; define a specific union type (e.g. export type
TeawareCategory = 'X' | 'Y' | 'Z' or whatever the real allowed values are) and
change Teaware.category to that union (or to TeawareCategory | null if
nullable), then update all usages that expect a string (constructors,
validators, DB mappers, tests, and any deserialization code) to use/validate the
new union type and adjust runtime parsing/validation where input can be
arbitrary.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 63a43bd0-3f47-4eea-8e6c-d9d341c6c9f4
📒 Files selected for processing (23)
backend/migrations/1814000000000-CreateTeaware.tsbackend/migrations/1814000000001-AddTeawareIdToNotes.tsbackend/src/app.module.tsbackend/src/notes/dto/create-note.dto.tsbackend/src/notes/entities/note.entity.tsbackend/src/teaware/dto/create-teaware.dto.tsbackend/src/teaware/dto/update-teaware.dto.tsbackend/src/teaware/entities/teaware.entity.tsbackend/src/teaware/teaware.controller.tsbackend/src/teaware/teaware.module.tsbackend/src/teaware/teaware.service.tsbackend/test/app.e2e-spec.tsbackend/test/setup/test-setup.tsbackend/test/suites/teaware.e2e-spec.tssrc/components/teaware/TeawareSection.tsxsrc/hooks/useNoteForm.tssrc/lib/api/index.tssrc/lib/api/notes.api.tssrc/lib/api/teaware.api.tssrc/pages/NewNote.tsxsrc/pages/NoteDetail.tsxsrc/pages/Settings.tsxsrc/types/index.ts
Comment on lines
+124
to
+125
| const created = await teawareApi.create(payload); | ||
| setTeawares((prev) => [...prev, created as Teaware]); |
Contributor
There was a problem hiding this comment.
새 다구 추가 시 목록 정렬 불일치
새로 생성된 다구가 배열 끝에 추가되지만, 백엔드는 isPinned DESC, createdAt DESC로 정렬합니다. 새 항목은 isPinned: false이므로 목록 중간에 위치해야 합니다.
🔧 정렬 유지 제안
const created = await teawareApi.create(payload);
- setTeawares((prev) => [...prev, created as Teaware]);
+ setTeawares((prev) => {
+ const updated = [...prev, created as Teaware];
+ return updated.sort((a, b) => {
+ if (a.isPinned !== b.isPinned) return b.isPinned ? 1 : -1;
+ return new Date(b.createdAt).getTime() - new Date(a.createdAt).getTime();
+ });
+ });또는 간단히 fetchTeawares()를 호출하여 서버에서 정렬된 목록을 다시 가져올 수 있습니다.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const created = await teawareApi.create(payload); | |
| setTeawares((prev) => [...prev, created as Teaware]); | |
| const created = await teawareApi.create(payload); | |
| setTeawares((prev) => { | |
| const updated = [...prev, created as Teaware]; | |
| return updated.sort((a, b) => { | |
| if (a.isPinned !== b.isPinned) return b.isPinned ? 1 : -1; | |
| return new Date(b.createdAt).getTime() - new Date(a.createdAt).getTime(); | |
| }); | |
| }); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/components/teaware/TeawareSection.tsx` around lines 124 - 125, Newly
created Teaware is appended to state with setTeawares([...prev, created]) but
server orders by isPinned DESC, createdAt DESC so the local list becomes
unsorted; fix by either (A) after teawareApi.create(payload) call
fetchTeawares() to replace local state with the server-sorted list, or (B)
insert the created item into the correct position locally using the same
comparator (isPinned DESC, createdAt DESC) before calling setTeawares; locate
this logic around teawareApi.create and setTeawares in TeawareSection (or use
the existing fetchTeawares helper) and implement one of these two approaches so
the UI order matches the backend.
Comment on lines
+250
to
+255
| type="number" | ||
| min={0} | ||
| value={form.capacity} | ||
| onChange={(e) => setForm((prev) => ({ ...prev, capacity: e.target.value }))} | ||
| placeholder="예: 120" | ||
| /> |
Contributor
There was a problem hiding this comment.
용량 입력 최소값 불일치
min={0}으로 설정되어 있지만, 백엔드 DTO는 @Min(1)입니다. 사용자가 0을 입력하면 서버에서 검증 오류가 발생합니다.
🔧 수정 제안
<Input
id="teaware-capacity"
type="number"
- min={0}
+ min={1}
value={form.capacity}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| type="number" | |
| min={0} | |
| value={form.capacity} | |
| onChange={(e) => setForm((prev) => ({ ...prev, capacity: e.target.value }))} | |
| placeholder="예: 120" | |
| /> | |
| type="number" | |
| min={1} | |
| value={form.capacity} | |
| onChange={(e) => setForm((prev) => ({ ...prev, capacity: e.target.value }))} | |
| placeholder="예: 120" | |
| /> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/components/teaware/TeawareSection.tsx` around lines 250 - 255, The
capacity input in TeawareSection uses min={0} which conflicts with the backend
DTO `@Min`(1); update the input to enforce min={1} and ensure the onChange stores
a numeric value (e.g., parseInt/Number) into form.capacity via setForm so the
client-side validation matches the backend (refer to TeawareSection, the
capacity input element, form.capacity and the setForm updater).
Comment on lines
+193
to
+195
| if (normalizedNote.teawareId != null) { | ||
| setTeawareId(normalizedNote.teawareId); | ||
| } |
Contributor
There was a problem hiding this comment.
수정 모드에서 다구 해제(null) 의도가 유실될 수 있습니다.
Line 193~195에서 teawareId가 null인 노트를 불러올 때 상태를 명시적으로 null로 덮어쓰지 않아 이전 값이 남을 수 있고, Line 374에서 null을 undefined로 바꿔 전송해 다구 연결 해제가 서버에 반영되지 않을 수 있습니다.
🐛 제안 수정안
- if (normalizedNote.teawareId != null) {
- setTeawareId(normalizedNote.teawareId);
- }
+ setTeawareId(normalizedNote.teawareId ?? null);- teawareId: teawareId ?? undefined,
+ teawareId: teawareId ?? null,Also applies to: 374-374
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/hooks/useNoteForm.ts` around lines 193 - 195, The current logic in
useNoteForm (around setTeawareId usage with normalizedNote.teawareId and the
payload preparation around line 374) fails to clear an existing teaware
selection because it only sets state when teawareId != null and converts null to
undefined when sending, so the server never receives a deliberate un-link.
Update the initializer that reads normalizedNote.teawareId to explicitly call
setTeawareId(null) when normalizedNote.teawareId === null (not only when !=
null), and update the payload construction (the function that builds the
submission payload / submit handler) to send teawareId: null when clearing
instead of omitting it or converting it to undefined so the server records the
removal.
| create: (data: CreateTeawareRequest) => apiClient.post<Teaware>('/teaware', data), | ||
| update: (id: number, data: UpdateTeawareRequest) => | ||
| apiClient.patch<Teaware>(`/teaware/${id}`, data), | ||
| remove: (id: number) => apiClient.delete<Teaware>(`/teaware/${id}`), |
Contributor
There was a problem hiding this comment.
remove 메서드 반환 타입 불일치
백엔드 DELETE /teaware/:id는 { message: string } 형태를 반환하지만 (teaware.controller.ts Line 63), 여기서는 Teaware로 타입 지정되어 있습니다. 현재 반환값을 사용하지 않아 문제는 없지만, 타입 정확성을 위해 수정을 권장합니다.
🔧 수정 제안
- remove: (id: number) => apiClient.delete<Teaware>(`/teaware/${id}`),
+ remove: (id: number) => apiClient.delete<{ message: string }>(`/teaware/${id}`),📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| remove: (id: number) => apiClient.delete<Teaware>(`/teaware/${id}`), | |
| remove: (id: number) => apiClient.delete<{ message: string }>(`/teaware/${id}`), |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/lib/api/teaware.api.ts` at line 20, The remove method in
src/lib/api/teaware.api.ts is typed to return Teaware but the backend DELETE
/teaware/:id returns { message: string } (see teaware.controller.ts Line 63);
update the generic on apiClient.delete used in the remove function to reflect
the actual response shape ({ message: string }) so the remove method's return
type matches the backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm run build✅ (frontend)cd backend && npm run build✅🤖 Generated with Claude Code
Summary by CodeRabbit
릴리스 노트