The bridge server moves out, and this package starts its sunset - #16
Merged
Merged
Conversation
flimkit_qupath_bridge re-exports flimkit_bridge through sys.modules so every existing import path still resolves. The console script and the FLIMKit plugin entry point move to the package that owns them, since two packages declaring either one is a coin toss. test_plugin.py and test_headless.py moved with the server. The version test no longer compares the jar against the server, because they version independently now. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The jar and the server version independently since the extraction, so comparing bridge_version against EXTENSION_VERSION would warn on every connection and the warning would stop meaning anything. protocol_version is what governs whether the two can talk. EXTENSION_VERSION stays as the jar's own version. versionIn had no callers left and goes with it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Discovery reads ~/.flimkit/bridge.json and falls back to qupath-bridge.json, and accepts either protocol name. The compatibility belongs on this side: once the jars in the wild are replaced, the server can stop writing the second file and nothing on the Python side has to carry the history. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Nothing QuPath-specific is left in it. The extension needs the jar and pip install flimkit-bridge, and neither of those is this package. The shim warns on import and goes in 0.7.0, which gives the jars in the wild time to be replaced by ones that find the bridge themselves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The add-on now depends on flimkit-bridge, which is not on PyPI yet, so pip could not resolve it and the package was never installed. Taking it from git matches how flimkit itself is installed here, and means CI tests against the server's main rather than its last release. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was nothing QuPath-specific in the server. Grepping all fourteen modules, the only QuPath-shaped things in 3075 lines were the discovery filename, the tool label, the tool id and one function name. It now lives in flimkit-bridge and the Fiji add-on is a second client of it.
What stays here is the jar, the catalog, the Groovy scripts that drive a real QuPath, and a Python shim that re-exports the shared package so nothing importing
flimkit_qupath_bridgebreaks. The shim warns on import and goes in 0.7.0.Two things changed on the Java side.
Discoveryreads~/.flimkit/bridge.jsonand falls back toqupath-bridge.json, accepting either protocol name, so the compatibility sits in the jar rather than the server writing two files forever. And the version warning comparesprotocol_versionrather thanbridge_versionagainstEXTENSION_VERSION, because the jar and the server version independently now and string equality would warn on every connection.3251 lines out. 241 Python tests and 48 Java tests pass,
./gradlew buildclean.Nothing published changes meaning: PyPI's latest is 0.4.0 and 0.5.0 was never released.
🤖 Generated with Claude Code