Trace a freehand region on the phasor plot - #15
Merged
Merged
Conversation
The bridge has accepted polygon cursors since #6 and nothing could produce one. Draw region turns a drag into an outline, which goes on the wire as type polygon with its vertices in (g, s). Building the request body moves to a static helper so it can be tested. Constructing a PhasorWindow needs a JavaFX toolkit, and the wire format is not a UI concern. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bridge has accepted polygon cursors since #6 and nothing could produce one. Draw region turns a drag on the phasor canvas into an outline, which goes on the wire as
type: polygonwith its vertices in(g, s).Points closer than three pixels apart are dropped, so a drag doesn't send hundreds of vertices. Fewer than three points isn't a region and says so. The toggle releases itself after each outline, so the plot goes back to placing ellipses. Drawn regions can't be dragged afterwards; remove and redraw.
Building the request body moves to a static helper. Constructing a
PhasorWindowneeds a JavaFX toolkit, so the instance method can't be tested, and the wire format isn't a UI concern anyway.Extension suite goes from 30 tests to 39.
./gradlew buildsucceeds, 232 Python tests pass.Driven by hand in QuPath against a real file before merging, with the jar installed and the bridge running: drawing a region, applying a filter and an IRF, and creating annotations all work.
This is the last piece of 0.5.0, which is still untagged.
🤖 Generated with Claude Code