Repository navigation
Pin the polygon phasor cursor, and take one through the endpoint - #14
Merged
Merged
Conversation
The polygon path has been reachable since #6 and had no tests. These cover selection, coexistence with an ellipse, the photon floor, the vertex minimum, labelling and the reported lifetimes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The polygon path was covered in Python at the function level and in Java at the payload level, with nothing crossing between them. These go over HTTP: a polygon covering the plane selects every valid pixel, two halves partition them, the lifetimes come back, the label image agrees with the reported count, and a two-vertex polygon is a 400. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cursor_maskshas dispatchedtype: 'polygon'since #6 and had no tests at all. This adds fourteen.Eight cover the function directly: selection against a two-population field, coexistence with an ellipse in one request, the photon floor, the three-vertex minimum, the rejection of an unknown cursor type, labelling, and the lifetimes reported back.
Six go over HTTP, which is where nothing was looking. A polygon covering the plane selects every valid pixel the density endpoint reports, two half-plane polygons partition them, the lifetimes and photon count come back, the label image agrees with the reported pixel count, a polygon and an ellipse are labelled apart, and a two-vertex polygon is a 400 rather than a 500.
The endpoint tests need
FLIMKIT_TEST_PTUand skip without it, like the rest of that file. With it set: 246 passed, 31 skipped.Nothing here changes behaviour. It pins the path the freehand tool depends on.
🤖 Generated with Claude Code